Bug 145838 – [EFL] Implement minibrowser:version Web UI using custom scheme.

• Component: WebKit EFL
• Status: RESOLVED WONTFIX

[Hyungwook Lee]

Implement about:version Web UI using custom scheme.

[Hyungwook Lee]

Created attachment 254649 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 254649 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254649&action=review

> Tools/MiniBrowser/efl/main.c:1041
> +    if (has_scheme(arg) || eina_str_has_prefix(arg, "javascript:") || eina_str_has_prefix(arg, "minibrowser:") || !strcasecmp(arg, "about:blank"))

Hmm... to be honest, MiniBrowser is a just simple application. In GTK MiniBrowser case, they didn't add new feature because minibrowser is just test application for own WebKit port. I don't know we need to add this feature to EFL MiniBrowser.

[Ryuan Choi]

(In reply to comment #2)
> Comment on attachment 254649 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=254649&action=review
> 
> > Tools/MiniBrowser/efl/main.c:1041
> > +    if (has_scheme(arg) || eina_str_has_prefix(arg, "javascript:") || eina_str_has_prefix(arg, "minibrowser:") || !strcasecmp(arg, "about:blank"))
> 
> Hmm... to be honest, MiniBrowser is a just simple application. In GTK
> MiniBrowser case, they didn't add new feature because minibrowser is just
> test application for own WebKit port. I don't know we need to add this
> feature to EFL MiniBrowser.

I also don't think that it is usefull for MiniBrowser to have this.

MiniBrowser is just simple browser to test basic functionality.

[Hyungwook Lee]

Comment on attachment 254649 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254649&action=review

>>> Tools/MiniBrowser/efl/main.c:1041
>>> +    if (has_scheme(arg) || eina_str_has_prefix(arg, "javascript:") || eina_str_has_prefix(arg, "minibrowser:") || !strcasecmp(arg, "about:blank"))
>> 
>> Hmm... to be honest, MiniBrowser is a just simple application. In GTK MiniBrowser case, they didn't add new feature because minibrowser is just test application for own WebKit port. I don't know we need to add this feature to EFL MiniBrowser.
> 
> I also don't think that it is usefull for MiniBrowser to have this.
> 
> MiniBrowser is just simple browser to test basic functionality.

I referenced GTK Mini Browser that supports 'about:minibrowser' scheme to show current version using Web UI.

I think Web UI is very useful function for Mini Browser to provide many functions easily.
ex) Settings, History, Cache Status, WebKit Debugging UI, etc...

Actually I want to implement WebKit Debugging UI and WebKit Setting UI using Web UI for developer who want to enable / disable some features in runtime.

[Csaba Osztrogonác]

Comment on attachment 254649 [details]
Patch

Cleared review? from attachment 254649 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).