Bug 145833

Summary: Bindings generator should generate code for Promise-based APIs
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, ggaren
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 145894    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Adding test
none
Patch for landing
none
Rebasing expectations none

youenn fablet
Reported 2015-06-10 00:37:15 PDT
Currently, binding code promise based APIs need to be made manually. It could be generated automatically based on direct use of DeferredWrapper or indirect use of DeferredWrapper through DOMPromise.
Attachments
Patch (6.49 KB, patch)
2015-06-10 02:00 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Adding test (13.63 KB, patch)
2015-06-11 00:36 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (13.62 KB, patch)
2015-06-11 11:30 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Rebasing expectations (13.72 KB, patch)
2015-06-12 01:35 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2015-06-10 02:00:31 PDT
Created attachment 254638 [details] Patch
youenn fablet
Comment 2 2015-06-11 00:36:54 PDT
Created attachment 254711 [details] Adding test
Darin Adler
Comment 3 2015-06-11 10:13:23 PDT
Comment on attachment 254711 [details] Adding test View in context: https://bugs.webkit.org/attachment.cgi?id=254711&action=review > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3662 > + push(@implContent, $indent . "JSPromiseDeferred* promiseDeferred = JSPromiseDeferred::create(exec, castedThis->globalObject());\n"); I think auto* would be better; no need to repeat the type twice on the same line of code.
youenn fablet
Comment 4 2015-06-11 11:30:27 PDT
Created attachment 254733 [details] Patch for landing
WebKit Commit Bot
Comment 5 2015-06-11 12:27:22 PDT
Comment on attachment 254733 [details] Patch for landing Clearing flags on attachment: 254733 Committed r185464: <http://trac.webkit.org/changeset/185464>
WebKit Commit Bot
Comment 6 2015-06-11 12:27:26 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 7 2015-06-11 13:15:35 PDT
Re-opened since this is blocked by bug 145894
Alexey Proskuryakov
Comment 8 2015-06-11 13:40:03 PDT
The rollout bug says that this broke bindings tests, however it seems to have broken more than just those: <https://build.webkit.org/builders/Apple%20Yosemite%20Release%20WK2%20(Tests)/builds/5960>.
youenn fablet
Comment 9 2015-06-12 01:35:17 PDT
Created attachment 254780 [details] Rebasing expectations
WebKit Commit Bot
Comment 10 2015-06-12 02:26:21 PDT
Comment on attachment 254780 [details] Rebasing expectations Clearing flags on attachment: 254780 Committed r185493: <http://trac.webkit.org/changeset/185493>
WebKit Commit Bot
Comment 11 2015-06-12 02:26:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.