Bug 145823 – Takes two delete key presses to delete pasted emoji up-pointing index finger with skin tone

• Component: HTML Editing
• Status: RESOLVED FIXED

[Darin Adler]

Takes two delete key presses to delete pasted emoji up-pointing index finger with skin tone

[Darin Adler]

Created attachment 254612 [details]
Patch

[Darin Adler]

<rdar://problem/20966101>

[WebKit Commit Bot]

Attachment 254612 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderText.cpp:1410:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Carlsson]

Comment on attachment 254612 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254612&action=review

> Source/WebCore/rendering/RenderText.cpp:1444
> +    // FIXME: Seems like this fancier case could be used on all platforms now, no
> +    // need for the #else case below.

What about Windows?

[Darin Adler]

Comment on attachment 254612 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254612&action=review

>> Source/WebCore/rendering/RenderText.cpp:1444
>> +    // need for the #else case below.
> 
> What about Windows?

I think it would be OK to have Windows take on this behavior.

[Darin Adler]

Committed r185393: <http://trac.webkit.org/changeset/185393>

[Alexey Proskuryakov]

Comment on attachment 254612 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254612&action=review

> Source/WebCore/rendering/RenderText.cpp:1440
> +    // FIXME: Unclear why this has so much handrolled code rather than using TextBreakIterator.

I'm not sure what this question asks. The behaviors are just different, because user expectations are different for deleting and for moving the insertion point. There are some test cases, although it's likely not fully covered. 

We should just keep the behavior 100% identical to AppKit.

>>> Source/WebCore/rendering/RenderText.cpp:1444
>>> +    // need for the #else case below.
>> 
>> What about Windows?
> 
> I think it would be OK to have Windows take on this behavior.

We investigated the behavior of Windows applications at the time, and matched it. I don't know if existing Windows WebKit clients prefer Mac or Windows behavior for editing now.