Bug 145821

Summary:

Change the PluginProcessManager data fetching function to take a completion handler

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	sam: review+

Anders Carlsson

Reported 2015-06-09 15:57:03 PDT

Change the PluginProcessManager data fetching function to take a completion handler

Attachments
Patch (10.69 KB, patch) 2015-06-09 15:59 PDT, Anders Carlsson	sam: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Anders Carlsson

Comment 1 2015-06-09 15:59:43 PDT

Created attachment 254610 [details] Patch

WebKit Commit Bot

Comment 2 2015-06-09 16:02:01 PDT

Attachment 254610 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp:111: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessManager.cpp:98: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.h:82: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.h:167: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Plugins/PluginProcessManager.h:65: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 5 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

Anders Carlsson

Comment 3 2015-06-09 16:10:15 PDT

Committed r185390: <http://trac.webkit.org/changeset/185390>

Note You need to log in before you can comment on or make changes to this bug.