Bug 145811

Summary: JavaScript bindings are unnecessarily checking for impossible empty JSValue arguments
Product: WebKit Reporter: Darin Adler <darin>
Component: WebCore JavaScriptAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, commit-queue, ggaren, kling, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 145815    
Bug Blocks:    
Attachments:
Description Flags
Patch koivisto: review+

Darin Adler
Reported 2015-06-09 12:37:33 PDT
JavaScript bindings are unnecessarily checking for impossible empty JSValue arguments
Attachments
Patch (90.57 KB, patch)
2015-06-09 12:47 PDT, Darin Adler 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2015-06-09 12:47:38 PDT
Created attachment 254592 [details] Patch
Darin Adler
Comment 2 2015-06-09 12:48:28 PDT
Brady, this is fixing the isEmpty issue I spotted in the patch you were working on.
Antti Koivisto
Comment 3 2015-06-09 12:54:48 PDT
Comment on attachment 254592 [details] Patch Nice cleanup. r=me
Darin Adler
Comment 4 2015-06-09 12:55:33 PDT
Committed r185373: <http://trac.webkit.org/changeset/185373>
WebKit Commit Bot
Comment 5 2015-06-09 14:17:13 PDT
Re-opened since this is blocked by bug 145815
Darin Adler
Comment 6 2015-06-09 14:18:59 PDT
Committed r185377: <http://trac.webkit.org/changeset/185377>
Note You need to log in before you can comment on or make changes to this bug.