Bug 145811

Summary: JavaScript bindings are unnecessarily checking for impossible empty JSValue arguments
Product: WebKit Reporter: Darin Adler <darin>
Component: WebCore JavaScriptAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, commit-queue, ggaren, kling, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 145815    
Bug Blocks:    
Attachments:
Description Flags
Patch koivisto: review+

Description Darin Adler 2015-06-09 12:37:33 PDT 
JavaScript bindings are unnecessarily checking for impossible empty JSValue arguments
Comment 1 Darin Adler 2015-06-09 12:47:38 PDT 
Created attachment 254592 [details]
Patch
Comment 2 Darin Adler 2015-06-09 12:48:28 PDT 
Brady, this is fixing the isEmpty issue I spotted in the patch you were working on.
Comment 3 Antti Koivisto 2015-06-09 12:54:48 PDT 
Comment on attachment 254592 [details]
Patch

Nice cleanup. r=me
Comment 4 Darin Adler 2015-06-09 12:55:33 PDT 
Committed r185373: <http://trac.webkit.org/changeset/185373>
Comment 5 WebKit Commit Bot 2015-06-09 14:17:13 PDT 
Re-opened since this is blocked by bug 145815
Comment 6 Darin Adler 2015-06-09 14:18:59 PDT 
Committed r185377: <http://trac.webkit.org/changeset/185377>