Bug 145799

Summary:

[GLib] Move files under Source/WTF/wtf/gobject to Source/WTF/wtf/glib

Product:

WebKit

Reporter:

Zan Dobersek <zan>

Component:

New Bugs

Assignee:

Zan Dobersek <zan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia, commit-queue, gustavo, mrobinson, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	cgarcia: review+, commit-queue: commit-queue-

Zan Dobersek

Reported 2015-06-09 06:27:31 PDT

[GLib] Move files under Source/WTF/wtf/gobject to Source/WTF/wtf/glib

Attachments
Patch (307.78 KB, patch) 2015-06-09 06:54 PDT, Zan Dobersek	no flags	Details Formatted Diff Diff
Patch (311.98 KB, patch) 2015-06-10 04:09 PDT, Zan Dobersek	cgarcia: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Zan Dobersek

Comment 1 2015-06-09 06:54:40 PDT

Created attachment 254565 [details] Patch

WebKit Commit Bot

Comment 2 2015-06-09 06:57:59 PDT

Attachment 254565 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp:48: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp:216: Extra space before ( in function call [whitespace/parens] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp:232: Extra space before ( in function call [whitespace/parens] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp:293: Extra space before ( in function call [whitespace/parens] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp:361: Extra space before ( in function call [whitespace/parens] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp:442: Extra space before ( in function call [whitespace/parens] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp:446: Extra space before ( in function call [whitespace/parens] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp:531: Extra space before ( in function call [whitespace/parens] [4] WARNING: File exempt from style guide. Skipping: "Source/WebKit2/UIProcess/API/gtk/WebKitColorChooser.h" ERROR: Source/WTF/wtf/glib/GMainLoopSource.cpp:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GMainLoopSource.cpp:117: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GMainLoopSource.cpp:134: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GMainLoopSource.cpp:169: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GMainLoopSource.cpp:186: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GMainLoopSource.cpp:203: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GMainLoopSource.cpp:220: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GMainLoopSource.cpp:266: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GMainLoopSource.cpp:283: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GThreadSafeMainLoopSource.cpp:63: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GThreadSafeMainLoopSource.cpp:70: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GThreadSafeMainLoopSource.cpp:77: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GThreadSafeMainLoopSource.cpp:84: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GThreadSafeMainLoopSource.cpp:91: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GThreadSafeMainLoopSource.cpp:98: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GMainLoopSource.h:96: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GMainLoopSource.h:97: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GMainLoopSource.h:98: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GMainLoopSource.h:99: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GTypedefs.h:34: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WTF/wtf/glib/GRefPtr.h:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/glib/GRefPtr.h:48: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/glib/GRefPtr.h:71: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/glib/GRefPtr.h:89: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/glib/GRefPtr.h:102: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/glib/GRefPtr.h:126: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/glib/GRefPtr.h:126: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] Total errors found: 35 in 208 files If any of these errors are false positives, please file a bug against check-webkit-style.

Zan Dobersek

Comment 3 2015-06-10 04:09:21 PDT

Created attachment 254645 [details] Patch

WebKit Commit Bot

Comment 4 2015-06-10 04:13:06 PDT

Attachment 254645 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp:48: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp:216: Extra space before ( in function call [whitespace/parens] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp:232: Extra space before ( in function call [whitespace/parens] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp:293: Extra space before ( in function call [whitespace/parens] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp:361: Extra space before ( in function call [whitespace/parens] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp:442: Extra space before ( in function call [whitespace/parens] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp:446: Extra space before ( in function call [whitespace/parens] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp:531: Extra space before ( in function call [whitespace/parens] [4] WARNING: File exempt from style guide. Skipping: "Source/WebKit2/UIProcess/API/gtk/WebKitColorChooser.h" ERROR: Source/WTF/wtf/glib/GMainLoopSource.cpp:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GMainLoopSource.cpp:117: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GMainLoopSource.cpp:134: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GMainLoopSource.cpp:169: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GMainLoopSource.cpp:186: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GMainLoopSource.cpp:203: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GMainLoopSource.cpp:220: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GMainLoopSource.cpp:266: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GMainLoopSource.cpp:283: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GThreadSafeMainLoopSource.cpp:63: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GThreadSafeMainLoopSource.cpp:70: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GThreadSafeMainLoopSource.cpp:77: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GThreadSafeMainLoopSource.cpp:84: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GThreadSafeMainLoopSource.cpp:91: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GThreadSafeMainLoopSource.cpp:98: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GMainLoopSource.h:96: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GMainLoopSource.h:97: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GMainLoopSource.h:98: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GMainLoopSource.h:99: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/glib/GTypedefs.h:34: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WTF/wtf/glib/GRefPtr.h:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/glib/GRefPtr.h:48: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/glib/GRefPtr.h:71: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/glib/GRefPtr.h:89: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WTF/wtf/glib/GRefPtr.h:102: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/glib/GRefPtr.h:126: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/glib/GRefPtr.h:126: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] Total errors found: 35 in 209 files If any of these errors are false positives, please file a bug against check-webkit-style.

Carlos Garcia Campos

Comment 5 2015-06-10 05:38:12 PDT

Comment on attachment 254645 [details] Patch This makes a lot of sense, thanks! Blindly review, since this is just moving existing code, I trust you and EWS :-)

WebKit Commit Bot

Comment 6 2015-06-12 04:18:28 PDT

Comment on attachment 254645 [details] Patch Rejecting attachment 254645 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 254645, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ing file Tools/WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp patching file Tools/WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp patching file Tools/WebKitTestRunner/PlatformGTK.cmake patching file Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp patching file Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Carlos Garcia Campos']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/5973668677025792

Zan Dobersek

Comment 7 2015-06-12 06:32:41 PDT

Committed r185502: <http://trac.webkit.org/changeset/185502>

Note You need to log in before you can comment on or make changes to this bug.