Summary: | [S60][3.1A][3.2] - Browser crashes in www.vertaa.fi | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Ligman <joseph.ligman> | ||||||
Component: | WebCore JavaScript | Assignee: | Joseph Ligman <joseph.ligman> | ||||||
Status: | CLOSED FIXED | ||||||||
Severity: | Critical | CC: | S60webkit | ||||||
Priority: | P2 | Keywords: | PlatformOnly | ||||||
Version: | 523.x (Safari 3) | ||||||||
Hardware: | S60 Hardware | ||||||||
OS: | S60 3rd edition | ||||||||
URL: | http://www.vertaa.fi | ||||||||
Attachments: |
|
Description
Joseph Ligman
2007-07-10 14:00:36 PDT
Created attachment 15466 [details]
create program node on the heap to avoid an overflow when parsing a large stringnode.
I'm assuming the memory allocated will be cleaned up by the garbage collector.
The patch is no good. It creates a memory leak. Created attachment 15488 [details]
delete all the ArgumentListNode's self elements in a loop to avoid recursion
The ArgumentListNode contains a pointer to itself, which makes a chain of elements. When the node is deleted it deletes itself which deletes itself recursively. When this recursion becomes large enough the crash occurs. To avoid this delete all the nodes in a loop and set them to null when the destructor is called.
Comment on attachment 15488 [details]
delete all the ArgumentListNode's self elements in a loop to avoid recursion
r = me
Bulk closing of all s60 platform bugs. Sorry for the noise! re-purposing InTSW keyword for use by QtWebkit team |