Bug 145767

Summary:

Web Inspector: Clearing active Timeline recording should stop capturing

Product:

WebKit

Reporter:

Matt Baker <mattbaker>

Component:

Web Inspector

Assignee:

Matt Baker <mattbaker>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

burg, commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Patch] Proposed Fix	none
[Patch] Proposed Fix	none

Description Matt Baker 2015-06-08 13:26:13 PDT

* SUMMARY
Clearing active Timeline recording should stop capturing.

Clearing the TimelineRecording resets start/end times and the current Rendering Frame index, so we're effectively creating a new Timeline recording anyway.

Comment 1 Radar WebKit Bug Importer 2015-06-08 13:26:50 PDT

<rdar://problem/21287839>

Comment 2 Matt Baker 2015-06-08 13:30:19 PDT

Created attachment 254505 [details]
[Patch] Proposed Fix

Comment 3 Matt Baker 2015-06-08 13:37:18 PDT

Before we stop capturing, maybe we should we check that:

WebInspector.timelineManager.activeRecording === this._recording

I'm fairly certain only the active timeline recording can be cleared, but this would make the change tolerant to future changes such as adding the ability to delete an arbitrary recording.

Comment 4 Matt Baker 2015-06-08 14:24:17 PDT

Created attachment 254507 [details]
[Patch] Proposed Fix

Comment 5 Joseph Pecoraro 2015-06-08 16:14:56 PDT

Comment on attachment 254507 [details]
[Patch] Proposed Fix

Sounds good! r=me

Comment 6 WebKit Commit Bot 2015-06-08 20:03:52 PDT

Comment on attachment 254507 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 254507

Committed r185349: <http://trac.webkit.org/changeset/185349>

Comment 7 WebKit Commit Bot 2015-06-08 20:03:56 PDT

All reviewed patches have been landed.  Closing bug.