Bug 145767

Summary: Web Inspector: Clearing active Timeline recording should stop capturing
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: burg, commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Patch] Proposed Fix
none
[Patch] Proposed Fix none

Matt Baker
Reported 2015-06-08 13:26:13 PDT
* SUMMARY Clearing active Timeline recording should stop capturing. Clearing the TimelineRecording resets start/end times and the current Rendering Frame index, so we're effectively creating a new Timeline recording anyway.
Attachments
[Patch] Proposed Fix (1.48 KB, patch)
2015-06-08 13:30 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
[Patch] Proposed Fix (1.55 KB, patch)
2015-06-08 14:24 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-06-08 13:26:50 PDT
<rdar://problem/21287839>
Matt Baker
Comment 2 2015-06-08 13:30:19 PDT
Created attachment 254505 [details] [Patch] Proposed Fix
Matt Baker
Comment 3 2015-06-08 13:37:18 PDT
Before we stop capturing, maybe we should we check that: WebInspector.timelineManager.activeRecording === this._recording I'm fairly certain only the active timeline recording can be cleared, but this would make the change tolerant to future changes such as adding the ability to delete an arbitrary recording.
Matt Baker
Comment 4 2015-06-08 14:24:17 PDT
Created attachment 254507 [details] [Patch] Proposed Fix
Joseph Pecoraro
Comment 5 2015-06-08 16:14:56 PDT
Comment on attachment 254507 [details] [Patch] Proposed Fix Sounds good! r=me
WebKit Commit Bot
Comment 6 2015-06-08 20:03:52 PDT
Comment on attachment 254507 [details] [Patch] Proposed Fix Clearing flags on attachment: 254507 Committed r185349: <http://trac.webkit.org/changeset/185349>
WebKit Commit Bot
Comment 7 2015-06-08 20:03:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.