Bug 145759 – [GTK] Fix parentheses warning in TestWebKitWebView.cpp

• Component: New Bugs
• Status: RESOLVED FIXED

[Csaba Osztrogonác]

clang build log:
-----------------
../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:478:22: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
    while (readBytes = g_input_stream_read(test->m_inputStream.get(), &buffer, 512, 0, &error.outPtr())) {
           ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:478:22: note: place parentheses around the assignment to silence this warning
    while (readBytes = g_input_stream_read(test->m_inputStream.get(), &buffer, 512, 0, &error.outPtr())) {
                     ^
           (                                                                                           )
../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:478:22: note: use '==' to turn this assignment into an equality comparison
    while (readBytes = g_input_stream_read(test->m_inputStream.get(), &buffer, 512, 0, &error.outPtr())) {
                     ^
                     ==
1 warning generated.


It isn't a bug, but a valid assignment, so we should use double parentheses to silence this warning.

[Csaba Osztrogonác]

Created attachment 254494 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 254494 [details]
Patch

Clearing flags on attachment: 254494

Committed r185321: <http://trac.webkit.org/changeset/185321>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.