Bug 145756

Summary:

[GTK] Remove the unused scroll function from WebPageGtk.cpp

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

New Bugs

Assignee:

Csaba Osztrogonác <ossy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia, commit-queue, ossy, zan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

145121

Attachments:

Description	Flags
Patch	none

Description Csaba Osztrogonác 2015-06-08 06:03:19 PDT

Before r164745 the scroll function in WebPageGtk.cpp was same 
as in WebPage.cpp, except the return type ( void vs bool ):
- https://trac.webkit.org/browser/trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp?rev=164744#L1937
- https://trac.webkit.org/browser/trunk/Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp#L91

But the scroll function in WebPageGtk.cpp is unused as clang noticed it
( https://trac.webkit.org/browser/trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp#L2202 )

../../Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp:91:24: warning: unused function 'scroll' [-Wunused-function]
static __inline__ void scroll(Page* page, ScrollDirection direction, ScrollGranularity granularity)

Comment 1 Csaba Osztrogonác 2015-06-08 06:04:08 PDT

Created attachment 254488 [details]
Patch

Comment 2 WebKit Commit Bot 2015-06-08 07:08:55 PDT

Comment on attachment 254488 [details]
Patch

Clearing flags on attachment: 254488

Committed r185315: <http://trac.webkit.org/changeset/185315>

Comment 3 WebKit Commit Bot 2015-06-08 07:08:58 PDT

All reviewed patches have been landed.  Closing bug.