Bug 145749

Summary: Subpixel rendering: Clip-path does not work properly on subpixel positions.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description zalan 2015-06-07 19:18:11 PDT
When clip-path is present and the content is subpixel positioned, the clipping is not correct.
Comment 1 zalan 2015-06-07 19:29:39 PDT
Created attachment 254466 [details]
Patch
Comment 2 zalan 2015-06-08 09:42:29 PDT
rdar://problem/20824305
Comment 3 Simon Fraser (smfr) 2015-06-08 09:56:33 PDT
Comment on attachment 254466 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254466&action=review

> Source/WebCore/rendering/RenderLayer.cpp:4087
> +        Path path = computeClipPath(paintingOffsetFromRoot, rootRelativeBounds, windRule);

Doesn't rootRelativeBounds need to be snapped?
Comment 4 zalan 2015-06-08 13:16:07 PDT
Created attachment 254504 [details]
Patch
Comment 5 zalan 2015-06-08 14:27:10 PDT
Created attachment 254508 [details]
Patch
Comment 6 WebKit Commit Bot 2015-06-08 17:29:44 PDT
Comment on attachment 254508 [details]
Patch

Clearing flags on attachment: 254508

Committed r185343: <http://trac.webkit.org/changeset/185343>
Comment 7 WebKit Commit Bot 2015-06-08 17:29:47 PDT
All reviewed patches have been landed.  Closing bug.