Bug 145712

Summary: Web Inspector: "Other" time in the framerate table is often negative
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Patch] Proposed Fix none

Description Matt Baker 2015-06-05 14:14:48 PDT
* SUMMARY
"Other" time in the framerate table is often negative.
Comment 1 Matt Baker 2015-06-05 14:15:22 PDT
<rdar://problem/21223666>
Comment 2 Matt Baker 2015-06-05 15:28:40 PDT
Created attachment 254393 [details]
[Patch] Proposed Fix
Comment 3 Simon Fraser (smfr) 2015-06-05 15:34:48 PDT
Comment on attachment 254393 [details]
[Patch] Proposed Fix

Can this be tested?
Comment 4 Matt Baker 2015-06-05 15:58:41 PDT
I'm not sure what type of layout test could cover this. I performed some ad hoc testing by scrolling while recording frames on sites that previously generated negative Other time.
Comment 5 Timothy Hatcher 2015-06-05 17:18:18 PDT
Comment on attachment 254393 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=254393&action=review

> Source/WebCore/inspector/InspectorTimelineAgent.cpp:676
> +        // Nested paint records are an implementation detail and add no information not already contained in the parent.

Can they be nested more than one level deep? Will this block more than one level nesting?
Comment 6 WebKit Commit Bot 2015-06-05 18:06:57 PDT
Comment on attachment 254393 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 254393

Committed r185278: <http://trac.webkit.org/changeset/185278>
Comment 7 WebKit Commit Bot 2015-06-05 18:07:01 PDT
All reviewed patches have been landed.  Closing bug.