Bug 145712

Summary: Web Inspector: "Other" time in the framerate table is often negative
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Patch] Proposed Fix none

Matt Baker
Reported 2015-06-05 14:14:48 PDT
* SUMMARY "Other" time in the framerate table is often negative.
Attachments
[Patch] Proposed Fix (2.00 KB, patch)
2015-06-05 15:28 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matt Baker
Comment 1 2015-06-05 14:15:22 PDT
<rdar://problem/21223666>
Matt Baker
Comment 2 2015-06-05 15:28:40 PDT
Created attachment 254393 [details] [Patch] Proposed Fix
Simon Fraser (smfr)
Comment 3 2015-06-05 15:34:48 PDT
Comment on attachment 254393 [details] [Patch] Proposed Fix Can this be tested?
Matt Baker
Comment 4 2015-06-05 15:58:41 PDT
I'm not sure what type of layout test could cover this. I performed some ad hoc testing by scrolling while recording frames on sites that previously generated negative Other time.
Timothy Hatcher
Comment 5 2015-06-05 17:18:18 PDT
Comment on attachment 254393 [details] [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=254393&action=review > Source/WebCore/inspector/InspectorTimelineAgent.cpp:676 > + // Nested paint records are an implementation detail and add no information not already contained in the parent. Can they be nested more than one level deep? Will this block more than one level nesting?
WebKit Commit Bot
Comment 6 2015-06-05 18:06:57 PDT
Comment on attachment 254393 [details] [Patch] Proposed Fix Clearing flags on attachment: 254393 Committed r185278: <http://trac.webkit.org/changeset/185278>
WebKit Commit Bot
Comment 7 2015-06-05 18:07:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.