Bug 145700

Summary: Disable the CFNetwork cache in the web process
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, clopez, commit-queue, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Description Anders Carlsson 2015-06-05 10:12:38 PDT
Disable the CFNetwork cache in the web process
Comment 1 Anders Carlsson 2015-06-05 10:13:10 PDT
Created attachment 254359 [details]
Patch
Comment 2 Geoffrey Garen 2015-06-05 10:14:49 PDT
Comment on attachment 254359 [details]
Patch

r=me
Comment 3 Antti Koivisto 2015-06-05 10:15:55 PDT
Comment on attachment 254359 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254359&action=review

> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:83
> +    printf("cache path is %s\n", networkCachePath.utf8().data());

:|
Comment 4 Anders Carlsson 2015-06-05 10:20:08 PDT
Committed r185251: <http://trac.webkit.org/changeset/185251>
Comment 5 Carlos Alberto Lopez Perez 2015-06-05 10:48:46 PDT
(In reply to comment #4)
> Committed r185251: <http://trac.webkit.org/changeset/185251>

This broke the GTK build.

../../Source/WebKit2/WebProcess/soup/WebProcessSoup.cpp:142:73: error: no member named 'diskCacheDirectory' in 'WebKit::WebProcessCreationParameters'
    WebCore::SoupNetworkSession::defaultSession().clearCache(parameters.diskCacheDirectory);
                                                             ~~~~~~~~~~ ^
../../Source/WebKit2/WebProcess/soup/WebProcessSoup.cpp:144:73: error: no member named 'diskCacheDirectory' in 'WebKit::WebProcessCreationParameters'
    String diskCachePath = WebCore::pathByAppendingComponent(parameters.diskCacheDirectory, "webkit");
                                                             ~~~~~~~~~~ ^
Comment 6 Carlos Garcia Campos 2015-06-07 03:54:35 PDT
This not only disabled the CFNetwork cache, but also the soup cache, because it removed the disk cache directory from the web process creation parameters. We can bring it back as soup only parameters, though. We will eventually disable it too, but I don't think we are ready.