Bug 145671

Summary:

Web Inspector: Switch to doughnut chart and remove idle time in the Rendering Frames timeline

Product:

WebKit

Reporter:

Matt Baker <mattbaker>

Component:

Web Inspector

Assignee:

Matt Baker <mattbaker>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Image] New chart UI	none
[Patch] Proposed Fix	none
[Patch] For Landing	none

Matt Baker

Reported 2015-06-04 16:18:53 PDT

* SUMMARY Switch to doughnut chart and remove idle time in the Rendering Frames timeline. We don't show idle time in the frames graph, so it makes sense to remove it from the chart.

Attachments
[Image] New chart UI (43.27 KB, image/jpeg) 2015-06-04 16:28 PDT, Matt Baker	no flags	Details
[Patch] Proposed Fix (4.67 KB, patch) 2015-06-04 16:33 PDT, Matt Baker	no flags	Details Formatted Diff Diff
[Patch] For Landing (5.16 KB, patch) 2015-06-05 09:05 PDT, Matt Baker	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-06-04 16:19:19 PDT

<rdar://problem/21251160>

Matt Baker

Comment 2 2015-06-04 16:28:29 PDT

Created attachment 254312 [details] [Image] New chart UI

Matt Baker

Comment 3 2015-06-04 16:33:42 PDT

Created attachment 254315 [details] [Patch] Proposed Fix

Timothy Hatcher

Comment 4 2015-06-04 20:38:05 PDT

Comment on attachment 254315 [details] [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=254315&action=review > Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js:-830 > - {label: WebInspector.UIString("Idle"), value: idleTime, color: this._chartColors.idle} You will need to update localized strings, unless Idle is used in other places.

Matt Baker

Comment 5 2015-06-05 09:05:29 PDT

Created attachment 254354 [details] [Patch] For Landing

WebKit Commit Bot

Comment 6 2015-06-05 11:12:00 PDT

Comment on attachment 254354 [details] [Patch] For Landing Clearing flags on attachment: 254354 Committed r185255: <http://trac.webkit.org/changeset/185255>

WebKit Commit Bot

Comment 7 2015-06-05 11:12:05 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.