Bug 145671

Summary: Web Inspector: Switch to doughnut chart and remove idle time in the Rendering Frames timeline
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Image] New chart UI
none
[Patch] Proposed Fix
none
[Patch] For Landing none

Description Matt Baker 2015-06-04 16:18:53 PDT
* SUMMARY
Switch to doughnut chart and remove idle time in the Rendering Frames timeline. We don't show idle time in the frames graph, so it makes sense to remove it from the chart.
Comment 1 Radar WebKit Bug Importer 2015-06-04 16:19:19 PDT
<rdar://problem/21251160>
Comment 2 Matt Baker 2015-06-04 16:28:29 PDT
Created attachment 254312 [details]
[Image] New chart UI
Comment 3 Matt Baker 2015-06-04 16:33:42 PDT
Created attachment 254315 [details]
[Patch] Proposed Fix
Comment 4 Timothy Hatcher 2015-06-04 20:38:05 PDT
Comment on attachment 254315 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=254315&action=review

> Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js:-830
> -            {label: WebInspector.UIString("Idle"), value: idleTime, color: this._chartColors.idle}

You will need to update localized strings, unless Idle is used in other places.
Comment 5 Matt Baker 2015-06-05 09:05:29 PDT
Created attachment 254354 [details]
[Patch] For Landing
Comment 6 WebKit Commit Bot 2015-06-05 11:12:00 PDT
Comment on attachment 254354 [details]
[Patch] For Landing

Clearing flags on attachment: 254354

Committed r185255: <http://trac.webkit.org/changeset/185255>
Comment 7 WebKit Commit Bot 2015-06-05 11:12:05 PDT
All reviewed patches have been landed.  Closing bug.