Bug 145659

Summary: [Cocoa] Add ASSERT to FontPlatformData::ctFont()
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch dino: review+

Myles C. Maxfield
Reported 2015-06-04 14:38:14 PDT
[Cocoa] Add ASSERT to FontPlatformData::ctFont()
Attachments
Patch (6.54 KB, patch)
2015-06-04 14:42 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (5.96 KB, patch)
2015-06-04 14:51 PDT, Myles C. Maxfield 		dino: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2015-06-04 14:42:10 PDT
Created attachment 254301 [details] Patch
Myles C. Maxfield
Comment 2 2015-06-04 14:45:16 PDT
Comment on attachment 254301 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254301&action=review > Source/WebCore/ChangeLog:10 > + FontCustomPlatformData and FontPlatformData include, this patch moves the definitions of This statement is false.
Myles C. Maxfield
Comment 3 2015-06-04 14:51:03 PDT
Created attachment 254303 [details] Patch
Dean Jackson
Comment 4 2015-06-04 14:54:34 PDT
Comment on attachment 254303 [details] Patch Personally, I think ENABLE() flags should be restricted to features that can be toggled externally at run time. I suggest you stick with a bare name.
Myles C. Maxfield
Comment 5 2015-06-04 15:00:39 PDT
Committed r185219: <http://trac.webkit.org/changeset/185219>
Note You need to log in before you can comment on or make changes to this bug.