Bug 145659

Summary: [Cocoa] Add ASSERT to FontPlatformData::ctFont()
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch dino: review+

Description Myles C. Maxfield 2015-06-04 14:38:14 PDT
[Cocoa] Add ASSERT to FontPlatformData::ctFont()
Comment 1 Myles C. Maxfield 2015-06-04 14:42:10 PDT
Created attachment 254301 [details]
Patch
Comment 2 Myles C. Maxfield 2015-06-04 14:45:16 PDT
Comment on attachment 254301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254301&action=review

> Source/WebCore/ChangeLog:10
> +        FontCustomPlatformData and FontPlatformData include, this patch moves the definitions of

This statement is false.
Comment 3 Myles C. Maxfield 2015-06-04 14:51:03 PDT
Created attachment 254303 [details]
Patch
Comment 4 Dean Jackson 2015-06-04 14:54:34 PDT
Comment on attachment 254303 [details]
Patch

Personally, I think ENABLE() flags should be restricted to features that can be toggled externally at run time. I suggest you stick with a bare name.
Comment 5 Myles C. Maxfield 2015-06-04 15:00:39 PDT
Committed r185219: <http://trac.webkit.org/changeset/185219>