Bug 145652

Summary: [Cocoa] Remove unnecessary code from FontPlatformData::ctFont()
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
kling: review+
Mac test for Hoefler none

Description Myles C. Maxfield 2015-06-04 12:42:02 PDT
Remove unnecessary code from FontPlatformData::ctFont()
Comment 1 Myles C. Maxfield 2015-06-04 12:43:52 PDT
Created attachment 254288 [details]
Patch
Comment 2 Myles C. Maxfield 2015-06-04 13:09:21 PDT
Created attachment 254292 [details]
Mac test for Hoefler
Comment 3 Myles C. Maxfield 2015-06-04 13:22:40 PDT
Relevant test is fast/text/line-initial-and-final-swashes.html
Comment 4 Andreas Kling 2015-06-04 14:00:12 PDT
Comment on attachment 254288 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254288&action=review

r=me

> Source/WebCore/ChangeLog:11
> +        No new tests because there is no behavior change.

This sounds a bit funny, but I guess you mean that there's no behavior change with the correct font version in place.
Comment 5 Myles C. Maxfield 2015-06-04 14:08:53 PDT
Committed r185217: <http://trac.webkit.org/changeset/185217>