| Summary: | Underline too close in vertical text | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dave Hyatt <hyatt> | ||||||||||||
| Component: | Layout and Rendering | Assignee: | Dave Hyatt <hyatt> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | 50167214, buildbot, commit-queue, mmaxfield, rniwa | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Dave Hyatt
2015-06-04 12:09:11 PDT
Created attachment 254285 [details]
Patch
Attachment 254285 [details] did not pass style-queue:
ERROR: Source/WebCore/style/InlineTextBoxStyle.cpp:53: Non-label code inside switch statements should be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/style/InlineTextBoxStyle.cpp:53: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 2 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 254285 [details] Patch Attachment 254285 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5346576339828736 Number of test failures exceeded the failure limit. Created attachment 254289 [details]
Archive of layout-test-results from ews103 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 254285 [details] Patch Attachment 254285 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6647914923294720 Number of test failures exceeded the failure limit. Created attachment 254290 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Comment on attachment 254285 [details]
Patch
Can this be tested? Maybe a ref test that clips out the new underline, but would expose the old one?
(In reply to comment #7) > Comment on attachment 254285 [details] > Patch > > Can this be tested? Maybe a ref test that clips out the new underline, but > would expose the old one? Yes, I wrote a test like this for skip: ink Created attachment 254355 [details]
Patch for EWS testing
Attachment 254355 [details] did not pass style-queue:
ERROR: Source/WebCore/style/InlineTextBoxStyle.cpp:53: Non-label code inside switch statements should be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/style/InlineTextBoxStyle.cpp:53: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 2 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 254363 [details]
Patch
Fixed in r185256. |