Bug 145651

Summary:

Underline too close in vertical text

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

Layout and Rendering

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

50167214, buildbot, commit-queue, mmaxfield, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	simon.fraser: review+, buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-mavericks	none
Archive of layout-test-results from ews107 for mac-mavericks-wk2	none
Patch for EWS testing	none
Patch	simon.fraser: review+

Dave Hyatt

Reported 2015-06-04 12:09:11 PDT

Underlines in vertical text for Chinese are too close to the text.

Attachments
Patch (2.56 KB, patch) 2015-06-04 12:12 PDT, Dave Hyatt	simon.fraser: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-mavericks (898.23 KB, application/zip) 2015-06-04 12:53 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews107 for mac-mavericks-wk2 (993.65 KB, application/zip) 2015-06-04 12:58 PDT, Build Bot	no flags	Details
Patch for EWS testing (3.47 KB, patch) 2015-06-05 09:14 PDT, Dave Hyatt	no flags	Details Formatted Diff Diff
Patch (5.31 KB, patch) 2015-06-05 10:53 PDT, Dave Hyatt	simon.fraser: review+	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Dave Hyatt

Comment 1 2015-06-04 12:12:36 PDT

Created attachment 254285 [details] Patch

WebKit Commit Bot

Comment 2 2015-06-04 12:14:28 PDT

Attachment 254285 [details] did not pass style-queue: ERROR: Source/WebCore/style/InlineTextBoxStyle.cpp:53: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/WebCore/style/InlineTextBoxStyle.cpp:53: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 3 2015-06-04 12:53:09 PDT

Comment on attachment 254285 [details] Patch Attachment 254285 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5346576339828736 Number of test failures exceeded the failure limit.

Build Bot

Comment 4 2015-06-04 12:53:13 PDT

Created attachment 254289 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5

Build Bot

Comment 5 2015-06-04 12:58:14 PDT

Comment on attachment 254285 [details] Patch Attachment 254285 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6647914923294720 Number of test failures exceeded the failure limit.

Build Bot

Comment 6 2015-06-04 12:58:18 PDT

Created attachment 254290 [details] Archive of layout-test-results from ews107 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Simon Fraser (smfr)

Comment 7 2015-06-04 13:47:42 PDT

Comment on attachment 254285 [details] Patch Can this be tested? Maybe a ref test that clips out the new underline, but would expose the old one?

Myles C. Maxfield

Comment 8 2015-06-04 13:53:42 PDT

(In reply to comment #7) > Comment on attachment 254285 [details] > Patch > > Can this be tested? Maybe a ref test that clips out the new underline, but > would expose the old one? Yes, I wrote a test like this for skip: ink

Dave Hyatt

Comment 9 2015-06-05 09:14:20 PDT

Created attachment 254355 [details] Patch for EWS testing

WebKit Commit Bot

Comment 10 2015-06-05 09:16:01 PDT

Attachment 254355 [details] did not pass style-queue: ERROR: Source/WebCore/style/InlineTextBoxStyle.cpp:53: Non-label code inside switch statements should be indented. [whitespace/indent] [4] ERROR: Source/WebCore/style/InlineTextBoxStyle.cpp:53: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Dave Hyatt

Comment 11 2015-06-05 10:53:49 PDT

Created attachment 254363 [details] Patch

Dave Hyatt

Comment 12 2015-06-05 11:27:12 PDT

Fixed in r185256.

yisibl

Comment 13 2015-12-13 23:27:43 PST

http://trac.webkit.org/changeset/185256

Note You need to log in before you can comment on or make changes to this bug.