Bug 145627

Summary:

[Cocoa] Expose interruptedForPolicyChangeError

Product:

WebKit

Reporter:

mitz

Component:

WebKit API

Assignee:

mitz

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Add _WKErrorCodeFrameLoadInterruptedByPolicyChange	andersca: review+

Description mitz 2015-06-03 18:20:30 PDT

[Cocoa] Expose interruptedForPolicyChangeError

Comment 1 mitz 2015-06-03 18:21:27 PDT

Created attachment 254228 [details]
Add _WKErrorCodeFrameLoadInterruptedByPolicyChange

Comment 2 Anders Carlsson 2015-06-03 18:22:16 PDT

Comment on attachment 254228 [details]
Add _WKErrorCodeFrameLoadInterruptedByPolicyChange

View in context: https://bugs.webkit.org/attachment.cgi?id=254228&action=review

> Source/WebKit2/ChangeLog:9
> +        kWKErrorCodeFrameLoadInterruptedByPolicyChange.

Can we static_assert that they are equal somewhere?

Comment 3 mitz 2015-06-04 12:39:49 PDT

Fixed in <http://trac.webkit.org/r185212>.

(In reply to comment #2)
> Comment on attachment 254228 [details]
> Add _WKErrorCodeFrameLoadInterruptedByPolicyChange
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=254228&action=review
> 
> > Source/WebKit2/ChangeLog:9
> > +        kWKErrorCodeFrameLoadInterruptedByPolicyChange.
> 
> Can we static_assert that they are equal somewhere?

I don’t know where we could do that. In the slightly longer term, we should change how we make errors so that we don’t make legacy errors when the modern API is used.