Bug 145612

Summary:

Caps lock indicator should not be shown in read-only or disabled field

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebCore Misc.

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=145613

Attachments:

Description	Flags
Patch	darin: review+

Daniel Bates

Reported 2015-06-03 13:08:12 PDT

We should not show the caps lock indicator in a read-only or disabled field.

Attachments
Patch (5.40 KB, patch) 2015-06-03 13:21 PDT, Daniel Bates	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2015-06-03 13:21:54 PDT

Created attachment 254202 [details] Patch We need to abstract the caps lock logic so as to support automated testing. Currently we check the actual hardware keyboard state for the caps lock key to determine whether to draw the caps lock indicator. Filed bug #145613 to add support for testing the caps lock indicator in DRT/WTR.

Radar WebKit Bug Importer

Comment 2 2015-06-03 13:24:54 PDT

<rdar://problem/21227454>

Daniel Bates

Comment 3 2015-06-03 15:36:11 PDT

Committed r185173: <http://trac.webkit.org/changeset/185173>

Note You need to log in before you can comment on or make changes to this bug.