Bug 145612

Summary: Caps lock indicator should not be shown in read-only or disabled field
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebCore Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=145613
Attachments:
Description Flags
Patch darin: review+

Description Daniel Bates 2015-06-03 13:08:12 PDT
We should not show the caps lock indicator in a read-only or disabled field.
Comment 1 Daniel Bates 2015-06-03 13:21:54 PDT
Created attachment 254202 [details]
Patch

We need to abstract the caps lock logic so as to support automated testing. Currently we check the actual hardware keyboard state for the caps lock key to determine whether to draw the caps lock indicator. Filed bug #145613 to add support for testing the caps lock indicator in DRT/WTR.
Comment 2 Radar WebKit Bug Importer 2015-06-03 13:24:54 PDT
<rdar://problem/21227454>
Comment 3 Daniel Bates 2015-06-03 15:36:11 PDT
Committed r185173: <http://trac.webkit.org/changeset/185173>