Bug 145603

Summary: [EFL] Implement window_object_cleared callback in EwkPageClient
Product: WebKit Reporter: Hyungwook Lee <hyungwook.lee>
Component: WebKit EFLAssignee: Hyungwook Lee <hyungwook.lee>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lucas.de.marchi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
Patch
none
Patch
none
Patch none

Description Hyungwook Lee 2015-06-03 05:23:40 PDT
We need to provide right timing for custom JS API that may needs to work at the beginning of the page.
But we only have two callbacks such as load_started and load_finished both are not able to use this propose.
Hence I think we need to provide window_object_cleared callback in EwkPageClient.
Comment 1 Hyungwook Lee 2015-06-03 06:13:14 PDT
Created attachment 254171 [details]
patch
Comment 2 Ryuan Choi 2015-06-03 13:53:29 PDT
Comment on attachment 254171 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254171&action=review

Looks good to me except doxygen improvement.

> Source/WebKit2/WebProcess/InjectedBundle/API/efl/ewk_page.h:62
> +     * @param page page that the window object has been cleared

We'd better to mention what `window object` means because window is ambiguous.
s/window object/JavaScript window object/ or let's add @note for the more description.
Comment 3 Hyungwook Lee 2015-06-03 19:44:20 PDT
Comment on attachment 254171 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254171&action=review

>> Source/WebKit2/WebProcess/InjectedBundle/API/efl/ewk_page.h:62
>> +     * @param page page that the window object has been cleared
> 
> We'd better to mention what `window object` means because window is ambiguous.
> s/window object/JavaScript window object/ or let's add @note for the more description.

I will change the comment as you mentioned.
Thanks.
Comment 4 Gyuyoung Kim 2015-06-03 20:39:04 PDT
Comment on attachment 254171 [details]
patch

LGTM. Please land after fixing the comment ryuan pointed out.
Comment 5 Hyungwook Lee 2015-06-03 21:02:13 PDT
Created attachment 254236 [details]
Patch
Comment 6 Hyungwook Lee 2015-06-03 21:08:42 PDT
Created attachment 254237 [details]
Patch
Comment 7 Hyungwook Lee 2015-06-03 21:21:27 PDT
Created attachment 254238 [details]
Patch
Comment 8 WebKit Commit Bot 2015-06-03 22:14:52 PDT
Comment on attachment 254238 [details]
Patch

Clearing flags on attachment: 254238

Committed r185188: <http://trac.webkit.org/changeset/185188>
Comment 9 WebKit Commit Bot 2015-06-03 22:14:56 PDT
All reviewed patches have been landed.  Closing bug.