Bug 145601

Summary: [Streams API] ReadableJSStream does not need a ReadableStreamSource
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, calvaris, commit-queue, darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 145640    
Attachments:
Description Flags
Patch
none
Patch for landing none

Description youenn fablet 2015-06-03 03:05:29 PDT
ReadableStreamSource was added as a way to define a simple interface for native sources.
This interface is not well suited to JS sources since the code needed to handle JS sources is scattered between ReadableJSStream and ReadableJSStream::Source.

It may be best to remove ReadableStreamSource from ReadableStream and ReadableJSStream.

We would then reintroduce it when supporting native streams as a member of a ReadableNativeStream.
ReadableNativeStream would be the equivalent of ReadableJSStream for native sources.
Comment 1 youenn fablet 2015-06-03 03:18:22 PDT
Created attachment 254164 [details]
Patch
Comment 2 Darin Adler 2015-06-03 14:14:38 PDT
Comment on attachment 254164 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254164&action=review

> Source/WebCore/Modules/streams/ReadableStream.h:87
> +    ReadableStream(ScriptExecutionContext&);

Should add explicit here.
Comment 3 youenn fablet 2015-06-03 23:50:30 PDT
Created attachment 254255 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2015-06-04 00:53:21 PDT
Comment on attachment 254255 [details]
Patch for landing

Clearing flags on attachment: 254255

Committed r185196: <http://trac.webkit.org/changeset/185196>
Comment 5 WebKit Commit Bot 2015-06-04 00:53:24 PDT
All reviewed patches have been landed.  Closing bug.