Web Inspector: Uncaught exception starting a NavigationBar drag and mousing over a different NavigationBar

• Component: Web Inspector
• Status: RESOLVED FIXED

[Joseph Pecoraro]

* SUMMARY
Uncaught exception starting a NavigationBar drag and mousing over a different NavigationBar

* STEPS TO REPRODUCE
1. Inspect a page
2. Show "Styles" > "Rules" sidebar for a dom element (two navigation bars right next to each other)
3. Click and hold "Rules"
4. Mouse over "Computed" (all is good)
5. Mouse over "Node" in the other navigation bar
  => Uncaught Exceptions

* EXCEPTION
[Error] TypeError: null is not an object (evaluating 'this.selectedNavigationItem.active = true')
  _mouseMoved
  (anonymous function)

[Joseph Pecoraro]

Created attachment 254140 [details]
[PATCH] Proposed Fix

[Timothy Hatcher]

Comment on attachment 254140 [details]
[PATCH] Proposed Fix

The mouse move on document was to allow tracking of the selected radio navigation item as you moved the mouse side to side. It might be best to just abort early in the mouse move listener. I'm not sure we use many of these radio items any more, only one I can think of is the Details sidebar / Styles sidebar panel. I assume those are the bars you saw this with?

[Timothy Hatcher]

Yep, I see you said that in the description. So doing this will break the old behavior of dragging side to side then mouse up to select an item when the mouse drifts outside the bar. I think that is fine. I doubt anyone does that in practice, I was just mimicking Xcode there.

[Joseph Pecoraro]

Ahh, I only made it (In reply to comment #3)
> Yep, I see you said that in the description. So doing this will break the
> old behavior of dragging side to side then mouse up to select an item when
> the mouse drifts outside the bar. I think that is fine. I doubt anyone does
> that in practice, I was just mimicking Xcode there.

Oops. I should be able to keep that working. I'll investigate a better fix.

[Joseph Pecoraro]

(In reply to comment #4)
> Ahh, I only made it (In reply to comment #3)
> > Yep, I see you said that in the description. So doing this will break the
> > old behavior of dragging side to side then mouse up to select an item when
> > the mouse drifts outside the bar. I think that is fine. I doubt anyone does
> > that in practice, I was just mimicking Xcode there.
> 
> Oops. I should be able to keep that working. I'll investigate a better fix.

Ahah! This behavior was broken, which is why I didn't notice to preserve it!

[Joseph Pecoraro]

Created attachment 254153 [details]
[PATCH] Proposed Fix

[Timothy Hatcher]

Comment on attachment 254153 [details]
[PATCH] Proposed Fix

Great!

[WebKit Commit Bot]

Comment on attachment 254153 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 254153

Committed r185151: <http://trac.webkit.org/changeset/185151>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.