Bug 145561

Summary: Backdrop filter is pulling in content from behind the window.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=146530
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2015-06-02 12:46:38 PDT
Backdrop filter is sized to the parent layer as opposed to the renderer's size.
Attachments
Patch (16.28 KB, patch)
2015-06-02 13:01 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (16.31 KB, patch)
2015-06-02 13:30 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2015-06-02 12:47:01 PDT
rdar://problem/20909309
alan
Comment 2 2015-06-02 13:01:09 PDT
Created attachment 254084 [details] Patch
Simon Fraser (smfr)
Comment 3 2015-06-02 13:10:31 PDT
Comment on attachment 254084 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254084&action=review > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1885 > + FloatRect contentBounds(0, 0, m_backdropFiltersRect.width(), m_backdropFiltersRect.height()); > + m_backdropLayer->setBounds(contentBounds); This could be m_backdropLayer->setBounds(FloatRect(FloatPoint(), m_backdropFiltersRect.size()); I kinda wish we had FloatRect(FloatSize) for this.
alan
Comment 4 2015-06-02 13:30:37 PDT
Created attachment 254094 [details] Patch
WebKit Commit Bot
Comment 5 2015-06-02 14:35:49 PDT
Comment on attachment 254094 [details] Patch Clearing flags on attachment: 254094 Committed r185124: <http://trac.webkit.org/changeset/185124>
WebKit Commit Bot
Comment 6 2015-06-02 14:35:53 PDT
All reviewed patches have been landed. Closing bug.
Brent Fulgham
Comment 7 2015-07-01 15:52:56 PDT
This change broke certain compositing features on Windows, primarily the ability to see the debug borders.
Note You need to log in before you can comment on or make changes to this bug.