Bug 145561

Summary:

Backdrop filter is pulling in content from behind the window.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=146530

Attachments:

Description	Flags
Patch	none
Patch	none

Description zalan 2015-06-02 12:46:38 PDT

Backdrop filter is sized to the parent layer as opposed to the renderer's size.

Comment 1 zalan 2015-06-02 12:47:01 PDT

rdar://problem/20909309

Comment 2 zalan 2015-06-02 13:01:09 PDT

Created attachment 254084 [details]
Patch

Comment 3 Simon Fraser (smfr) 2015-06-02 13:10:31 PDT

Comment on attachment 254084 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254084&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1885
> +    FloatRect contentBounds(0, 0, m_backdropFiltersRect.width(), m_backdropFiltersRect.height());
> +    m_backdropLayer->setBounds(contentBounds);

This could be m_backdropLayer->setBounds(FloatRect(FloatPoint(), m_backdropFiltersRect.size());

I kinda wish we had FloatRect(FloatSize) for this.

Comment 4 zalan 2015-06-02 13:30:37 PDT

Created attachment 254094 [details]
Patch

Comment 5 WebKit Commit Bot 2015-06-02 14:35:49 PDT

Comment on attachment 254094 [details]
Patch

Clearing flags on attachment: 254094

Committed r185124: <http://trac.webkit.org/changeset/185124>

Comment 6 WebKit Commit Bot 2015-06-02 14:35:53 PDT

All reviewed patches have been landed.  Closing bug.

Comment 7 Brent Fulgham 2015-07-01 15:52:56 PDT

This change broke certain compositing features on Windows, primarily the ability to see the debug borders.