Bug 145558

Summary: Add more tests for "should open external urls" flag
Product: WebKit Reporter: Brady Eidson <beidson>
Component: Tools / TestsAssignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, mitz, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch v1 none

Description Brady Eidson 2015-06-02 12:13:14 PDT
Add more tests for "should open external urls" flag

Suggested in https://bugs.webkit.org/show_bug.cgi?id=145280
Comment 1 Brady Eidson 2015-06-02 12:22:57 PDT
In the other bug, Geoff Garen suggested:
---
Other interesting test cases:

(1) Do a top-level (Safari-like) navigation that sets the flag to true, then another that sets it to false. Flag should be false.

(2) Do a top-level (Safari-like) navigation that sets the flag to false, then another that sets it to true. Flag should be true.

(3) Do a top-level (Safari-like) navigation that sets the flag to false, then a programmatic click event on a link. Flag should be false.
Comment 2 Brady Eidson 2015-06-02 12:37:15 PDT
Created attachment 254081 [details]
Patch v1
Comment 3 Brady Eidson 2015-06-02 12:38:36 PDT
Comment on attachment 254081 [details]
Patch v1

Geoff rubber-stamped these in person
Comment 4 Brady Eidson 2015-06-02 12:40:49 PDT
http://trac.webkit.org/changeset/185115