Summary: | Calling FrameView::viewportContentsChanged() after style recalcs is too expensive | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
Component: | Layout and Rendering | Assignee: | Chris Dumez <cdumez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, kangil.han, kondapallykalyan, simon.fraser | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Chris Dumez
2015-06-02 10:58:32 PDT
Created attachment 254075 [details]
Patch
Comment on attachment 254075 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254075&action=review > Source/WebCore/ChangeLog:22 > + No new tests, already covered by: > + fast/images/animated-gif-webkit-transform.html Unfortunate that there is no way to test the performance improvement and catch if we screw it up. We should think about a way to regression test this kind of change. I have a similar issue with my patch that cuts down on unnecessary layout when updating an image but not its dimensions. Comment on attachment 254075 [details]
Patch
Simon, can you please take a quick look as well before I land?
Comment on attachment 254075 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254075&action=review > Source/WebCore/rendering/RenderLayerCompositor.h:124 > + void didRecalcStyleWithNoPendingLayout(bool& updatedCompositedLayers); I think it would be nicer if this were just the return value, with a comment saying what the return value means. Created attachment 254080 [details]
Patch
(In reply to comment #4) > Comment on attachment 254075 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=254075&action=review > > > Source/WebCore/rendering/RenderLayerCompositor.h:124 > > + void didRecalcStyleWithNoPendingLayout(bool& updatedCompositedLayers); > > I think it would be nicer if this were just the return value, with a comment > saying what the return value means. Ok, done. Comment on attachment 254080 [details] Patch Clearing flags on attachment: 254080 Committed r185118: <http://trac.webkit.org/changeset/185118> All reviewed patches have been landed. Closing bug. |