Bug 145551

Summary: [Streams API] ReadableStreamReader::closed() should be called once by binding code
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, commit-queue, darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2015-06-02 02:07:29 PDT
ReadableStreamReader.closed JS attribute is just an accessor to the promise. We should only call ReadableStreamReader::closed() when we create the actual promise to set the callbacks properly.
Attachments
Patch (2.04 KB, patch)
2015-06-02 02:10 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.98 KB, patch)
2015-06-02 23:39 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2015-06-02 02:10:05 PDT
Created attachment 254061 [details] Patch
Darin Adler
Comment 2 2015-06-02 11:28:47 PDT
Comment on attachment 254061 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254061&action=review > Source/WebCore/bindings/js/JSReadableStreamReaderCustom.cpp:70 > + return m_closedPromiseDeferred.get()->promise(); Is the call to .get() really needed?
youenn fablet
Comment 3 2015-06-02 23:39:15 PDT
Created attachment 254158 [details] Patch for landing
youenn fablet
Comment 4 2015-06-02 23:40:52 PDT
Thanks for the review. > > Source/WebCore/bindings/js/JSReadableStreamReaderCustom.cpp:70 > > + return m_closedPromiseDeferred.get()->promise(); > > Is the call to .get() really needed? Right, I removed it in the landing patch.
WebKit Commit Bot
Comment 5 2015-06-03 00:35:28 PDT
Comment on attachment 254158 [details] Patch for landing Clearing flags on attachment: 254158 Committed r185149: <http://trac.webkit.org/changeset/185149>
WebKit Commit Bot
Comment 6 2015-06-03 00:35:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.