Bug 145544

Summary: Web Inspector: Type token text descenders touch bottom of container
Product: WebKit Reporter: Jonathan Wells <jonowells>
Component: Web InspectorAssignee: Jonathan Wells <jonowells>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[IMAGE] descenders.
none
[PATCH] CSS fix.
none
[IMAGE] Fixed image. none

Jonathan Wells
Reported 2015-06-01 20:34:02 PDT
Created attachment 254044 [details] [IMAGE] descenders. The text inside the colored type tokens for the type profiler touch the bottom, breaking the color at the bottom edge of the token. The padding should be adjusted so this isn't the case.
Attachments
[IMAGE] descenders. (44.41 KB, image/png)
2015-06-01 20:34 PDT, Jonathan Wells 		no flags
Details
[PATCH] CSS fix. (1.34 KB, patch)
2015-06-01 20:39 PDT, Jonathan Wells 		no flags
DetailsFormatted DiffDiff
[IMAGE] Fixed image. (44.41 KB, image/png)
2015-06-01 22:49 PDT, Jonathan Wells 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-06-01 20:34:33 PDT
<rdar://problem/21196162>
Jonathan Wells
Comment 2 2015-06-01 20:39:10 PDT
Created attachment 254045 [details] [PATCH] CSS fix.
WebKit Commit Bot
Comment 3 2015-06-01 22:48:28 PDT
Comment on attachment 254045 [details] [PATCH] CSS fix. Clearing flags on attachment: 254045 Committed r185105: <http://trac.webkit.org/changeset/185105>
WebKit Commit Bot
Comment 4 2015-06-01 22:48:31 PDT
All reviewed patches have been landed. Closing bug.
Jonathan Wells
Comment 5 2015-06-01 22:49:40 PDT
Created attachment 254053 [details] [IMAGE] Fixed image.
Note You need to log in before you can comment on or make changes to this bug.