Bug 145495

Summary:

Make FrameLoader methods that take PassRefPtr<Event> take raw pointers instead

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebCore Misc.

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, esprehn+autocc, gyuyoung.kim, japhet

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch v1	none

Brady Eidson

Reported 2015-05-30 21:21:34 PDT

Make FrameLoader methods that take PassRefPtr<Event> take raw pointers instead Ownership of the event is rarely actually being transferred, and the code paths are definitely not hot, so we're not actually worried about ref churn. But this will make the related code cleaner and less likely to run across bizarre correctness issues like that found in https://bugs.webkit.org/show_bug.cgi?id=145472 and fixed in http://trac.webkit.org/changeset/185033

Attachments
Patch v1 (10.21 KB, patch) 2015-05-30 21:23 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2015-05-30 21:23:54 PDT

Created attachment 253970 [details] Patch v1

WebKit Commit Bot

Comment 2 2015-05-30 22:53:28 PDT

Comment on attachment 253970 [details] Patch v1 Clearing flags on attachment: 253970 Committed r185037: <http://trac.webkit.org/changeset/185037>

WebKit Commit Bot

Comment 3 2015-05-30 22:53:32 PDT

All reviewed patches have been landed. Closing bug.

Darin Adler

Comment 4 2015-06-01 10:10:09 PDT

Comment on attachment 253970 [details] Patch v1 These should be references unless the event can be null.

Brady Eidson

Comment 5 2015-06-01 10:18:34 PDT

(In reply to comment #4) > Comment on attachment 253970 [details] > Patch v1 > > These should be references unless the event can be null. The event can be null.

Note You need to log in before you can comment on or make changes to this bug.