| Summary: | [iOS] Tiling coverage sometimes inflated by outdated scale factor. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||
| Component: | Layout and Rendering | Assignee: | Andreas Kling <kling> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, commit-queue, simon.fraser | ||||||
| Priority: | P2 | Keywords: | InRadar, Performance | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Andreas Kling
2015-05-30 18:16:59 PDT
Created attachment 253968 [details]
Patch idea
Attachment 253968 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:49: Bad include order. Mixing system and custom headers. [build/include_order] [4]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 253968 [details] Patch idea View in context: https://bugs.webkit.org/attachment.cgi?id=253968&action=review Good to finally nuke the tile allocation bug :) > Source/WebCore/platform/graphics/ca/TileController.cpp:316 > +FloatRect TileController::computeTileCoverageRect(const FloatSize& newSize, const FloatRect& previousVisibleRect, const FloatRect& visibleRect, float contentsScale) const Shouldn't this be a double? Created attachment 253969 [details]
Patch for landing
Comment on attachment 253969 [details] Patch for landing Clearing flags on attachment: 253969 Committed r185036: <http://trac.webkit.org/changeset/185036> All reviewed patches have been landed. Closing bug. Nice fix! |