REGRESSION (179771): zooming on facebook images covers image

• Component: New Bugs
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

REGRESSION (179771): zooming on facebook images covers image

[Simon Fraser (smfr)]

Created attachment 253943 [details]
Patch

[Jon Lee]

*** Bug 145484 has been marked as a duplicate of this bug. ***

[Simon Fraser (smfr)]

Comment on attachment 253943 [details]
Patch

Re-instating this patch, since I think fixing LayoutRect::scale to not overflow is hard.

[zalan]

(In reply to comment #3)
> Comment on attachment 253943 [details]
> Patch
> 
> Re-instating this patch, since I think fixing LayoutRect::scale to not
> overflow is hard.
I think the proper fix is to preserve the infinite state of the LayoutRect regardless of the scale; something like this

diff --git a/Source/WebCore/platform/graphics/LayoutRect.cpp b/Source/WebCore/platform/graphics/LayoutRect.cpp
index f899004..a2f53b9 100644
--- a/Source/WebCore/platform/graphics/LayoutRect.cpp
+++ b/Source/WebCore/platform/graphics/LayoutRect.cpp
@@ -106,12 +106,13 @@ void LayoutRect::uniteIfNonZero(const LayoutRect& other)
 
 void LayoutRect::scale(float s)
 {
-    m_location.scale(s, s);
-    m_size.scale(s);
+    scale(s, s);
 }
 
 void LayoutRect::scale(float xScale, float yScale)
 {
+    if (isInfinite())
+        return;
     m_location.scale(xScale, yScale);
     m_size.scale(xScale, yScale);
 }

[zalan]

Created attachment 253963 [details]
Patch

[Build Bot]

Comment on attachment 253963 [details]
Patch

Attachment 253963 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5482701704396800

New failing tests:
compositing/layer-creation/zoomed-clip-intersection.html

[Build Bot]

Created attachment 253967 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[zalan]

Committed r185093: <http://trac.webkit.org/changeset/185093>

[zalan]

rdar://problem/21003563