Bug 145474 – Web Inspector: Resources tab navigation sidebar should have a type filter header

• Component: Web Inspector
• Status: RESOLVED FIXED

[Timothy Hatcher]

Created attachment 253920 [details]
Screenshot with Patch

The filter would filter by resource type and make the sidebar look better aligned with the navigation bar of the content browser.

[Radar WebKit Bug Importer]

<rdar://problem/21166032>

[Timothy Hatcher]

Created attachment 253921 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 253921 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253921&action=review

r=me

> Source/WebInspectorUI/ChangeLog:81
> [phone]  Timothy Hatcher  <[e-mail]>
> +
> +        Need a short description (OOPS!).
> +        Need the bug URL (OOPS!).

Double changelog!

> Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.css:2
> + * Copyright (C) 2013 Apple Inc. All rights reserved.

2015.

> Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js:47
> +            scopeBarItem.__resourceType = value;

Should we use a Symbol instead of __foo? I'm fine either way, I think the __foo is easier to type then using a Symbol.

> Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js:187
> +        var selectedScopBarItem = this._scopeBar.selectedItems[0];

Typo: Variable name "selectedScopBarItem" => "selectedScopeBarItem"

> Source/WebInspectorUI/UserInterface/Views/ScopeBar.js:71
> +        this._itemsById = {};

Map?

[Timothy Hatcher]

https://trac.webkit.org/r185044