| Summary: | Web Inspector: Resources tab navigation sidebar should have a type filter header | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||||
| Component: | Web Inspector | Assignee: | Timothy Hatcher <timothy> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
Created attachment 253921 [details]
Patch
Comment on attachment 253921 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253921&action=review r=me > Source/WebInspectorUI/ChangeLog:81 > +2015-05-29 Timothy Hatcher <timothy@apple.com> > + > + Need a short description (OOPS!). > + Need the bug URL (OOPS!). Double changelog! > Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.css:2 > + * Copyright (C) 2013 Apple Inc. All rights reserved. 2015. > Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js:47 > + scopeBarItem.__resourceType = value; Should we use a Symbol instead of __foo? I'm fine either way, I think the __foo is easier to type then using a Symbol. > Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js:187 > + var selectedScopBarItem = this._scopeBar.selectedItems[0]; Typo: Variable name "selectedScopBarItem" => "selectedScopeBarItem" > Source/WebInspectorUI/UserInterface/Views/ScopeBar.js:71 > + this._itemsById = {}; Map? |
Created attachment 253920 [details] Screenshot with Patch The filter would filter by resource type and make the sidebar look better aligned with the navigation bar of the content browser.