Bug 145462

Summary: Add stub implementation of MediaRemoteControls, part of Media Session spec
Product: WebKit Reporter: Matt Rajca <mrajca>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: commit-queue, conrad_shultz, eric.carlson, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 145411    
Attachments:
Description Flags
Patch
none
Patch (re-based) none

Matt Rajca
Reported 2015-05-29 12:03:03 PDT
Add a stub implementation of MediaRemoteControls, part of the Media Session spec: https://mediasession.spec.whatwg.org/
Attachments
Patch (15.58 KB, patch)
2015-05-29 15:11 PDT, Matt Rajca 		no flags
DetailsFormatted DiffDiff
Patch (re-based) (15.64 KB, patch)
2015-06-01 10:46 PDT, Matt Rajca 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-05-29 12:05:05 PDT
<rdar://problem/21162651>
Matt Rajca
Comment 2 2015-05-29 15:11:31 PDT
Created attachment 253923 [details] Patch
Conrad Shultz
Comment 3 2015-05-31 15:59:15 PDT
Comment on attachment 253923 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253923&action=review > Source/WebCore/Modules/mediasession/MediaRemoteControls.cpp:29 > +#if ENABLE(MEDIA_SESSION) Would it make sense for this to be above the includes?
Eric Carlson
Comment 4 2015-06-01 06:43:54 PDT
Comment on attachment 253923 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253923&action=review >> Source/WebCore/Modules/mediasession/MediaRemoteControls.cpp:29 >> +#if ENABLE(MEDIA_SESSION) > > Would it make sense for this to be above the includes? This is the pattern typically used throughout WebKit. > Source/WebCore/Modules/mediasession/MediaRemoteControls.h:53 > + virtual ~MediaRemoteControls(); Does the destructor need to be public?
Matt Rajca
Comment 5 2015-06-01 10:46:08 PDT
Created attachment 254008 [details] Patch (re-based)
Matt Rajca
Comment 6 2015-06-01 10:50:50 PDT
The destructor needs to be visible to the public `deref` method (not sure why inline comments I make on the original patch don't show up here like everyone else's). I attached a re-based patch.
WebKit Commit Bot
Comment 7 2015-06-01 12:06:07 PDT
Comment on attachment 254008 [details] Patch (re-based) Clearing flags on attachment: 254008 Committed r185069: <http://trac.webkit.org/changeset/185069>
WebKit Commit Bot
Comment 8 2015-06-01 12:06:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.