Bug 145459

Summary: Small FrameLoader refactoring
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, japhet
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch v1 achristensen: review+

Description Brady Eidson 2015-05-29 09:11:55 PDT 
Small FrameLoader refactoring

A couple of the load methods take a whole bunch of arguments broken out from a FrameLoadRequest.
The callers already *have* a FrameLoadRequest.

They should just pass along the entire FrameLoadRequest.
Comment 1 Brady Eidson 2015-05-29 09:14:33 PDT 
Created attachment 253902 [details]
Patch v1
Comment 2 Alex Christensen 2015-05-29 09:26:14 PDT 
Comment on attachment 253902 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=253902&action=review

lgtm except one thing:

> Source/WebCore/loader/FrameLoader.cpp:918
> +    FrameLoadRequest frameLoadRequest(m_frame.document()->securityOrigin(), ResourceRequest(url), "_self", LockHistory::No, LockBackForwardList::No, ShouldSendReferrer::MaybeSendReferrer, AllowNavigationToInvalidURL::Yes, NewFrameOpenerPolicy::Suppress, ReplaceDocumentIfJavaScriptURL);

I think this should have LockBackForwardList::Yes instead of no.
Comment 3 Brady Eidson 2015-05-29 09:32:22 PDT 
http://trac.webkit.org/changeset/184987