Bug 145453

Summary:

Only show volume controls when audio tracks are found.

Product:

WebKit

Reporter:

Roger Fong <roger_fong>

Component:

Media

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

dino, roger_fong

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none

Roger Fong

Reported 2015-05-28 20:54:15 PDT

rdar://problem/21153927 Some of the layout tests test that a video with no audio track should have no volume control. Right now our volume control starts off visible. It should only become visible was audio tracks have been found. This must have regressed at some point seeing as we have a test for it. Maybe a line of code that was accidentally removed.

Attachments
patch (1.59 KB, patch) 2015-05-28 20:57 PDT, Roger Fong	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Roger Fong

Comment 1 2015-05-28 20:57:14 PDT

Created attachment 253891 [details] patch

Roger Fong

Comment 2 2015-05-28 21:49:38 PDT

(In reply to comment #0) > rdar://problem/21153927 > > Some of the layout tests test that a video with no audio track should have > no volume control. > Right now our volume control starts off visible. > It should only become visible was audio tracks have been found. > > This must have regressed at some point seeing as we have a test for it. > Maybe a line of code that was accidentally removed. Correction: we do do this above correctly, it's actually that if the video has an error and doesn't load we used to only show the buttons to the left of the timeline (rewind and play). This decision seems arbitrary though so I'm not actually sure this fix matters at all...

Note You need to log in before you can comment on or make changes to this bug.