Bug 145443

Summary:

GraphicsLayerCA should start out with m_intersectsCoverageRect=false

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Layout and Rendering

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kling, simon.fraser

Priority:

Keywords:

InRadar, Performance

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch idea	simon.fraser: review-
Smaller patch with a test!	none

Description Andreas Kling 2015-05-28 13:53:22 PDT

<rdar://problem/19685798>

Currently GraphicsLayerCA::setVisibleAndCoverageRects() will return early if neither the visible or coverage rects have changed.
This may cause us to not update m_intersectsCoverageRect if the layer's own rect has changed.

Comment 1 Andreas Kling 2015-05-28 14:00:23 PDT

Created attachment 253861 [details]
Patch idea

Comment 2 Simon Fraser (smfr) 2015-05-28 14:44:50 PDT

Comment on attachment 253861 [details]
Patch idea

Andreas and I talked about this, and he's going to look at an alternate solution, and a test case.

Comment 3 Andreas Kling 2015-05-28 16:03:28 PDT

Created attachment 253873 [details]
Smaller patch with a test!

Comment 4 Andreas Kling 2015-05-28 16:48:47 PDT

Comment on attachment 253873 [details]
Smaller patch with a test!

Clearing flags on attachment: 253873

Committed r184968: <http://trac.webkit.org/changeset/184968>

Comment 5 Andreas Kling 2015-05-28 16:48:50 PDT

All reviewed patches have been landed.  Closing bug.