Bug 145443

Summary: GraphicsLayerCA should start out with m_intersectsCoverageRect=false
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: kling, simon.fraser
Priority: P2 Keywords: InRadar, Performance
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch idea
simon.fraser: review-
Smaller patch with a test! none

Andreas Kling
Reported 2015-05-28 13:53:22 PDT
<rdar://problem/19685798> Currently GraphicsLayerCA::setVisibleAndCoverageRects() will return early if neither the visible or coverage rects have changed. This may cause us to not update m_intersectsCoverageRect if the layer's own rect has changed.
Attachments
Patch idea (3.44 KB, patch)
2015-05-28 14:00 PDT, Andreas Kling 		simon.fraser: review-
DetailsFormatted DiffDiff
Smaller patch with a test! (7.69 KB, patch)
2015-05-28 16:03 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2015-05-28 14:00:23 PDT
Created attachment 253861 [details] Patch idea
Simon Fraser (smfr)
Comment 2 2015-05-28 14:44:50 PDT
Comment on attachment 253861 [details] Patch idea Andreas and I talked about this, and he's going to look at an alternate solution, and a test case.
Andreas Kling
Comment 3 2015-05-28 16:03:28 PDT
Created attachment 253873 [details] Smaller patch with a test!
Andreas Kling
Comment 4 2015-05-28 16:48:47 PDT
Comment on attachment 253873 [details] Smaller patch with a test! Clearing flags on attachment: 253873 Committed r184968: <http://trac.webkit.org/changeset/184968>
Andreas Kling
Comment 5 2015-05-28 16:48:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.