Bug 145440

Summary:

Rename HTMLMediaSession to HTMLMediaElementSession in anticipation of Media Session API

Product:

WebKit

Reporter:

Matt Rajca <mrajca>

Component:

Media

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Trivial

CC:

commit-queue, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

145411

Attachments:

Description	Flags
Patch	none
Patch	none

Description Matt Rajca 2015-05-28 10:44:59 PDT

As discussed with Eric Carlson and Jer Noble, we should rename HTMLMediaSession to HTMLMediaElementSession to reserve "media session" for the Media Session API (bug 145411).

Comment 1 Radar WebKit Bug Importer 2015-05-28 10:46:13 PDT

<rdar://problem/21142951>

Comment 2 Matt Rajca 2015-05-28 12:10:30 PDT

Created attachment 253854 [details]
Patch

Comment 3 WebKit Commit Bot 2015-05-28 12:13:17 PDT

Attachment 253854 [details] did not pass style-queue:


ERROR: Source/WebCore/html/HTMLMediaElementSession.cpp:30:  You should not add a blank line before implementation file's own header.  [build/include_order] [4]
ERROR: Source/WebCore/html/HTMLMediaElementSession.cpp:58:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 2 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 Darin Adler 2015-05-28 12:47:32 PDT

Comment on attachment 253854 [details]
Patch

Generally we only want to use the HTML prefix for classes actually exposed to the DOM. So I think MediaElementSession would be better.

Comment 5 Matt Rajca 2015-05-28 12:56:49 PDT

I'll send out a new patch. I already ran this change by Eric as well.

Comment 6 Matt Rajca 2015-05-28 14:51:36 PDT

Created attachment 253866 [details]
Patch

Comment 7 WebKit Commit Bot 2015-05-28 14:53:15 PDT

Attachment 253866 [details] did not pass style-queue:


ERROR: Source/WebCore/html/MediaElementSession.cpp:30:  You should not add a blank line before implementation file's own header.  [build/include_order] [4]
ERROR: Source/WebCore/html/MediaElementSession.cpp:58:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 2 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 8 WebKit Commit Bot 2015-05-28 16:03:52 PDT

Comment on attachment 253866 [details]
Patch

Clearing flags on attachment: 253866

Committed r184966: <http://trac.webkit.org/changeset/184966>

Comment 9 WebKit Commit Bot 2015-05-28 16:03:56 PDT

All reviewed patches have been landed.  Closing bug.