Bug 145413

Summary:

Assertion hit in WebPage::didChangeSelection()

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Forms

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

rniwa

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Chris Dumez 2015-05-27 14:11:38 PDT

We sometimes hit the "ASSERT(layoutCount == view->layoutCount())" assertion in WebPage::didChangeSelection(). We manage to prevent synchronous layouts in most cases when calling editorState() however, it seems it can still happening. Crashing in this case seems overkill and can be annoying to other developers, especially considering the implications are only performance-related.

We should drop the assertion.
 
Radar: <rdar://problem/21001129>

Comment 1 Chris Dumez 2015-05-27 14:14:58 PDT

Created attachment 253800 [details]
Patch

Comment 2 Chris Dumez 2015-05-27 14:51:36 PDT

Comment on attachment 253800 [details]
Patch

Clearing flags on attachment: 253800

Committed r184923: <http://trac.webkit.org/changeset/184923>

Comment 3 Chris Dumez 2015-05-27 14:51:40 PDT

All reviewed patches have been landed.  Closing bug.