Bug 145413

Summary: Assertion hit in WebPage::didChangeSelection()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: FormsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: rniwa
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2015-05-27 14:11:38 PDT
We sometimes hit the "ASSERT(layoutCount == view->layoutCount())" assertion in WebPage::didChangeSelection(). We manage to prevent synchronous layouts in most cases when calling editorState() however, it seems it can still happening. Crashing in this case seems overkill and can be annoying to other developers, especially considering the implications are only performance-related. We should drop the assertion. Radar: <rdar://problem/21001129>
Attachments
Patch (2.53 KB, patch)
2015-05-27 14:14 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2015-05-27 14:14:58 PDT
Created attachment 253800 [details] Patch
Chris Dumez
Comment 2 2015-05-27 14:51:36 PDT
Comment on attachment 253800 [details] Patch Clearing flags on attachment: 253800 Committed r184923: <http://trac.webkit.org/changeset/184923>
Chris Dumez
Comment 3 2015-05-27 14:51:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.