Bug 145412

Summary: REGRESSION: These sorting idioms used by Peacekeeper and Browsermark are ~20X slower
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, fpizlo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch darin: review+

Description Geoffrey Garen 2015-05-27 11:33:19 PDT 
REGRESSION: These sorting idioms used by Peacekeeper and Browsermark are ~20X slower
Comment 1 Geoffrey Garen 2015-05-27 11:50:40 PDT 
Created attachment 253797 [details]
Patch
Comment 2 Geoffrey Garen 2015-05-27 11:51:12 PDT 
This is a partial fix for the regression.
Comment 3 Geoffrey Garen 2015-05-27 11:53:28 PDT 
(I'm still waiting on a build to get performance numbers.)
Comment 4 Darin Adler 2015-05-27 11:53:59 PDT 
Comment on attachment 253797 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253797&action=review

> Source/JavaScriptCore/ChangeLog:10
> +        Use @toString instead of the String constructor because calls to the
> +        String constructor are never optimized. (See
> +        https://bugs.webkit.org/show_bug.cgi?id=144458.)

What’s the downside of using @toString? Would we want to change this back some day if resolved bug 144458?
Comment 5 Geoffrey Garen 2015-05-27 12:59:45 PDT 
There's no downside to @toString.

Assuming that ES6 settles on making ToString and String identical in behavior, we might eventually remove @toString once @String is fast.
Comment 6 Geoffrey Garen 2015-05-27 13:42:14 PDT 
Committed r184917: <http://trac.webkit.org/changeset/184917>
Comment 7 Geoffrey Garen 2015-05-27 15:54:06 PDT 
Reopening to attach new patch.
Comment 8 Geoffrey Garen 2015-05-27 15:54:07 PDT 
Created attachment 253806 [details]
Patch
Comment 9 Geoffrey Garen 2015-05-27 16:26:39 PDT 
Created attachment 253811 [details]
Patch
Comment 10 Geoffrey Garen 2015-05-27 16:43:35 PDT 
Committed r184926: <http://trac.webkit.org/changeset/184926>
Comment 11 Geoffrey Garen 2015-05-29 17:11:10 PDT 
Reopening to attach new patch.
Comment 12 Geoffrey Garen 2015-05-29 17:11:12 PDT 
Created attachment 253940 [details]
Patch
Comment 13 Geoffrey Garen 2015-05-29 17:13:54 PDT 
Created attachment 253941 [details]
Patch
Comment 14 Geoffrey Garen 2015-06-01 11:40:49 PDT 
Committed r185067: <http://trac.webkit.org/changeset/185067>