Bug 145379

Summary: Try to use StringView when comparing JSStrings for equality.
Product: WebKit Reporter: Andreas Kling <kling>
Component: JavaScriptCoreAssignee: Andreas Kling <kling>
Status: REOPENED ---    
Severity: Normal CC: commit-queue, darin, ysuzuki
Priority: P2 Keywords: Performance
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 145456    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Andreas Kling 2015-05-26 08:50:08 PDT 
Checking two JSStrings for equality should use StringView to avoid reifying substrings.
Comment 1 Andreas Kling 2015-05-26 08:50:32 PDT 
Created attachment 253705 [details]
Patch
Comment 2 WebKit Commit Bot 2015-05-26 10:28:47 PDT 
Comment on attachment 253705 [details]
Patch

Clearing flags on attachment: 253705

Committed r184860: <http://trac.webkit.org/changeset/184860>
Comment 3 WebKit Commit Bot 2015-05-26 10:28:51 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Yusuke Suzuki 2015-05-29 00:38:40 PDT 
Hi, kling. What do you think about it?
https://bugs.webkit.org/show_bug.cgi?id=145360
Comment 5 WebKit Commit Bot 2015-05-29 00:43:54 PDT 
Re-opened since this is blocked by bug 145456