Bug 145379

Summary: Try to use StringView when comparing JSStrings for equality.
Product: WebKit Reporter: Andreas Kling <kling>
Component: JavaScriptCoreAssignee: Andreas Kling <kling>
Status: REOPENED    
Severity: Normal CC: commit-queue, darin, ysuzuki
Priority: P2 Keywords: Performance
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 145456    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Andreas Kling
Reported 2015-05-26 08:50:08 PDT
Checking two JSStrings for equality should use StringView to avoid reifying substrings.
Attachments
Patch (2.73 KB, patch)
2015-05-26 08:50 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2015-05-26 08:50:32 PDT
Created attachment 253705 [details] Patch
WebKit Commit Bot
Comment 2 2015-05-26 10:28:47 PDT
Comment on attachment 253705 [details] Patch Clearing flags on attachment: 253705 Committed r184860: <http://trac.webkit.org/changeset/184860>
WebKit Commit Bot
Comment 3 2015-05-26 10:28:51 PDT
All reviewed patches have been landed. Closing bug.
Yusuke Suzuki
Comment 4 2015-05-29 00:38:40 PDT
Hi, kling. What do you think about it? https://bugs.webkit.org/show_bug.cgi?id=145360
WebKit Commit Bot
Comment 5 2015-05-29 00:43:54 PDT
Re-opened since this is blocked by bug 145456
Note You need to log in before you can comment on or make changes to this bug.