Summary: | [ARM] Build SVGPathElement.cpp with -O2 due to a GCC bug | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
Component: | New Bugs | Assignee: | Csaba Osztrogonác <ossy> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cgarcia, clopez, ossy, silvio.frischi | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 108645 | ||||||
Attachments: |
|
Description
Csaba Osztrogonác
2015-05-26 03:41:39 PDT
Created attachment 253703 [details] Patch -O2 fixed this issue for me long long time ago - https://bugs.webkit.org/show_bug.cgi?id=140162#c94 , but I haven't tested it now. I tested the cmake version check, it adds the O2 flag for all 4.9 version older than the not yet released 4.9.3. There is only one possible issue ... Linaro has released GCC versions with the 4.9.3 version number which conatain this bug, but their latest 4.9.3 (15.03) release already contains the upstream fix. But I don't think if we can/should check the non official GCC version numbers. Comment on attachment 253703 [details]
Patch
Ok, let's try with this. Thanks Ossy!
Comment on attachment 253703 [details] Patch Clearing flags on attachment: 253703 Committed r184857: <http://trac.webkit.org/changeset/184857> All reviewed patches have been landed. Closing bug. This patch does not work for allinone builds, in which case svg/SVGAllInOne.cpp is still compiled with -O3 and fails. |