Bug 14536

Summary: Unnecessary layout done when mousing down in text field
Product: WebKit Reporter: Adele Peterson <adele>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, bdakin, hyatt, mitz
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on:    
Bug Blocks: 44883    
Attachments:
Description Flags
shark sample
none
testcase
none
Avoid spurious layout due to mutating inner renderer's styles
none
Avoid spurious layout due to mutating inner renderer's styles bdakin: review+

Adele Peterson
Reported 2007-07-05 17:13:56 PDT
Unnecessary layout done when mousing down in text field. Adam and I were testing a text field with 500,000 characters, and we noticed some sluggishness clicking in and out of the text field. We profiled it with Shark, and saw that the slowness is coming from laying out the large run of text. But it seems unnecessary to have to relayout just for clicking in the field.
Attachments
shark sample (690.66 KB, application/octet-stream)
2007-07-05 17:18 PDT, Adam Roben (:aroben) 		no flags
Details
testcase (1.22 KB, text/html)
2007-07-05 17:21 PDT, Adam Roben (:aroben) 		no flags
Details
Avoid spurious layout due to mutating inner renderer's styles (2.20 KB, patch)
2007-07-06 01:47 PDT, mitz 		no flags
DetailsFormatted DiffDiff
Avoid spurious layout due to mutating inner renderer's styles (4.28 KB, patch)
2007-07-06 05:40 PDT, mitz 		bdakin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2007-07-05 17:18:59 PDT
Created attachment 15408 [details] shark sample Here's a sample from clicking in a text field with many characters in it.
Adam Roben (:aroben)
Comment 2 2007-07-05 17:21:16 PDT
Created attachment 15409 [details] testcase Enter "500000" in the second text field and press "Test Length". That will fill the first text field with 500000 characters.
mitz
Comment 3 2007-07-06 01:47:19 PDT
Created attachment 15414 [details] Avoid spurious layout due to mutating inner renderer's styles
mitz
Comment 4 2007-07-06 01:59:54 PDT
Comment on attachment 15414 [details] Avoid spurious layout due to mutating inner renderer's styles I think I actually need to preserve the current values, not reset them, in case layout doesn't get called again (which is the entire point of this exercise).
mitz
Comment 5 2007-07-06 05:40:57 PDT
Created attachment 15417 [details] Avoid spurious layout due to mutating inner renderer's styles
Beth Dakin
Comment 6 2007-07-06 09:37:05 PDT
Comment on attachment 15417 [details] Avoid spurious layout due to mutating inner renderer's styles Looks good!
Mark Rowe (bdash)
Comment 7 2007-07-06 19:36:39 PDT
Landed in r24083.
Note You need to log in before you can comment on or make changes to this bug.