Bug 145345

Summary:

Remove unused definitions of WEBKIT_VERSION_MIN_REQUIRED

Product:

WebKit

Reporter:

mitz

Component:

WebKit API

Assignee:

mitz

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, sam, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Don’t define WEBKIT_VERSION_MIN_REQUIRED	sam: review+

Description mitz 2015-05-23 09:49:55 PDT

Remove unused definitions of WEBKIT_VERSION_MIN_REQUIRED

Comment 1 mitz 2015-05-23 09:52:53 PDT

Created attachment 253647 [details]
Don’t define WEBKIT_VERSION_MIN_REQUIRED

Comment 2 Sam Weinig 2015-05-24 12:26:55 PDT

Comment on attachment 253647 [details]
Don’t define WEBKIT_VERSION_MIN_REQUIRED

View in context: https://bugs.webkit.org/attachment.cgi?id=253647&action=review

I would note replacing $(GCC_PREPROCESSOR_DEFINITIONS) with $(inherited) in the ChangeLogs.

> Source/JavaScriptCore/Configurations/Base.xcconfig:59
>  GCC_PRECOMPILE_PREFIX_HEADER = YES;
> -GCC_PREPROCESSOR_DEFINITIONS = $(DEBUG_DEFINES) WEBKIT_VERSION_MIN_REQUIRED=WEBKIT_VERSION_LATEST HAVE_HEADER_DETECTION_H JSC_OBJC_API_AVAILABLE_MAC_OS_X_1080 $(FEATURE_DEFINES) $(GCC_PREPROCESSOR_DEFINITIONS);
> +GCC_PREPROCESSOR_DEFINITIONS = $(inherited) HAVE_HEADER_DETECTION_H JSC_OBJC_API_AVAILABLE_MAC_OS_X_1080 $(FEATURE_DEFINES) $(GCC_PREPROCESSOR_DEFINITIONS);

Add back $(DEBUG_DEFINES) and replace $(GCC_PREPROCESSOR_DEFINITIONS) with $(inherited).

Comment 3 mitz 2015-05-24 12:31:15 PDT

Committed <http://trac.webkit.org/r184845>.