Bug 145335

Summary:

Web Inspector: Adopt Object.setPrototypeOf

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

burg, commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

DoNotImportToRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none
[PATCH] Proposed Fix	none

Joseph Pecoraro

Reported 2015-05-22 20:48:28 PDT

* SUMMARY Adopt Object.setPrototypeOf and provide better API view for it. Just implemented in JavaScriptCore. For the one place where we set __proto__ that won't easily be converted to ES6 classes, we can use the method. And remember to improve the parameter list for the API view.

Attachments
[PATCH] Proposed Fix (1.96 KB, patch) 2015-05-22 20:49 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
[PATCH] Proposed Fix (1.38 KB, patch) 2015-05-22 21:06 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2015-05-22 20:49:30 PDT

Created attachment 253630 [details] [PATCH] Proposed Fix

Joseph Pecoraro

Comment 2 2015-05-22 21:04:41 PDT

I'm going to update Native parameter lists separately. Just focus on adoption here.

Joseph Pecoraro

Comment 3 2015-05-22 21:06:00 PDT

Created attachment 253631 [details] [PATCH] Proposed Fix

WebKit Commit Bot

Comment 4 2015-05-22 23:31:15 PDT

Comment on attachment 253631 [details] [PATCH] Proposed Fix Clearing flags on attachment: 253631 Committed r184820: <http://trac.webkit.org/changeset/184820>

WebKit Commit Bot

Comment 5 2015-05-22 23:31:19 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.