Bug 145329

Summary: Clean up logic for updating caps lock indicator state
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebCore Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Daniel Bates 2015-05-22 16:58:15 PDT 
We can take advantage of the fact that the caps lock indicator is implemented in the shadow DOM to simplify the logic for updating its state. Notice that TextFieldInputType listens for DOM focus and DOM blur events and updates the state of the caps lock indicator. It's unnecessary to explicitly update the state of the caps lock indicator using EventHandler::capsLockStateMayHaveChanged().
Comment 1 Daniel Bates 2015-05-22 17:00:39 PDT 
Created attachment 253618 [details]
Patch
Comment 2 Daniel Bates 2015-05-29 16:59:43 PDT 
Comment on attachment 253618 [details]
Patch

Clearing flags on attachment: 253618

Committed r185020: <http://trac.webkit.org/changeset/185020>
Comment 3 Daniel Bates 2015-05-29 16:59:46 PDT 
All reviewed patches have been landed.  Closing bug.