Bug 145303

Summary: [JSC] Speed up new array construction in Array.prototype.splice().
Product: WebKit Reporter: Andreas Kling <kling>
Component: JavaScriptCoreAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, rniwa
Priority: P2 Keywords: Performance
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
benjamin: review+
Patch for landing none

Andreas Kling
Reported 2015-05-22 01:22:22 PDT
Let's use Ryosuke's JSArray::fastSlice() for Array.prototype.splice() too :-)
Attachments
Patch (6.32 KB, patch)
2015-05-22 01:22 PDT, Andreas Kling 		benjamin: review+
DetailsFormatted DiffDiff
Patch for landing (6.41 KB, patch)
2015-05-22 01:49 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2015-05-22 01:22:45 PDT
Created attachment 253584 [details] Patch
Benjamin Poulain
Comment 2 2015-05-22 01:32:05 PDT
Comment on attachment 253584 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253584&action=review > Source/JavaScriptCore/runtime/ArrayPrototype.cpp:669 > + for (unsigned k = 0; k < deleteCount; k++) { ++k > Source/JavaScriptCore/runtime/JSArray.cpp:684 > + case ALL_INT32_INDEXING_TYPES: > + case ALL_DOUBLE_INDEXING_TYPES: > + case ALL_CONTIGUOUS_INDEXING_TYPES: { I don't think that changes anything, fastSlice() always happen after isJSArray().
Andreas Kling
Comment 3 2015-05-22 01:49:19 PDT
Created attachment 253585 [details] Patch for landing
WebKit Commit Bot
Comment 4 2015-05-22 03:18:58 PDT
Comment on attachment 253585 [details] Patch for landing Clearing flags on attachment: 253585 Committed r184767: <http://trac.webkit.org/changeset/184767>
WebKit Commit Bot
Comment 5 2015-05-22 03:19:02 PDT
All reviewed patches have been landed. Closing bug.
Andreas Kling
Comment 6 2015-05-26 09:00:24 PDT
*** Bug 145302 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.