[Streams API] Implement ReadableStreamReader.releaseLock

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[youenn fablet]

Implement https://streams.spec.whatwg.org/#reader-release-lock

[youenn fablet]

Created attachment 254954 [details]
Patch

[Darin Adler]

Comment on attachment 254954 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254954&action=review

> Source/WebCore/Modules/streams/ReadableStream.h:70
> +    bool hasReadPendingRequests() { return m_readRequests.size(); }

Often we use !isEmpty instead of size for such things. In theory isEmpty might be faster than !size.

> Source/WebCore/Modules/streams/ReadableStreamReader.h:36
> +#include "ExceptionCode.h"

If we need only the type for ExceptionCode, then we typically declare it with:

    typedef int ExceptionCode;

rather than including the header.

[youenn fablet]

Created attachment 255096 [details]
Patch for landing

[youenn fablet]

Created attachment 255097 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 255097 [details]
Patch for landing

Clearing flags on attachment: 255097

Committed r185697: <http://trac.webkit.org/changeset/185697>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.