Bug 145297

Summary: build.webkit.org/dashboard: Simplify BuildbotQueueView creation code
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: dburkart, thorton, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch thorton: review+

Alexey Proskuryakov
Reported 2015-05-21 22:54:27 PDT
Currently, caller has to split queues into debug and release subtypes before creating any queue. This doesn't make sense, because it's a presentation decision that should be left to views, and they don't necessarily divide queues by this parameter.
Attachments
proposed patch (12.59 KB, patch)
2015-05-21 22:58 PDT, Alexey Proskuryakov 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2015-05-21 22:58:58 PDT
Created attachment 253577 [details] proposed patch
Tim Horton
Comment 2 2015-05-22 11:30:08 PDT
Comment on attachment 253577 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=253577&action=review > Tools/ChangeLog:10 > + It is up to the view to decide how to present the queues, and whether to split double space
Alexey Proskuryakov
Comment 3 2015-05-22 12:04:22 PDT
Committed <http://trac.webkit.org/r184784>.
Note You need to log in before you can comment on or make changes to this bug.