| Summary: | [iOS] Tell AVPlayerLayer when we enter optimized fullscreen mode. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dbates, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=145414 | ||||||
| Attachments: |
|
||||||
|
Description
Jer Noble
2015-05-21 18:15:12 PDT
Created attachment 253570 [details]
Patch
Committed r184760: <http://trac.webkit.org/changeset/184760> (In reply to comment #2) > Committed r184760: <http://trac.webkit.org/changeset/184760> This broke the internal iOS bots because the file AVPlayerViewController_WebKitOnly.h, included in file Source/WebCore/platform/spi/mac/AVFoundationSPI.h, may not exist. As far as I can tell from the looking at the patch we don't seem to make use of (In reply to comment #4) > As far as I can tell from the looking at the patch we don't seem to make use > of I meant to write: As far as I can tell from the looking at the patch we don't seem to make use of AVPlayerViewController_WebKitOnly.h. We should remove it. (In reply to comment #5) > As far as I can tell from the looking at the patch we don't seem to make use > of AVPlayerViewController_WebKitOnly.h. We should remove it. Filed bug #145414 to remove the inclusion of header AVPlayerViewController_WebKitOnly.h from AVFoundationSPI.h. Follow up build-fix landed by Daniel Bates in https://trac.webkit.org/r184924. |