Bug 145289

Summary: [iOS] Tell AVPlayerLayer when we enter optimized fullscreen mode.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=145414
Attachments:
Description Flags
Patch eric.carlson: review+

Jer Noble
Reported 2015-05-21 18:15:12 PDT
[iOS] Tell AVPlayerLayer when we enter optimized fullscreen mode.
Attachments
Patch (8.90 KB, patch)
2015-05-21 18:28 PDT, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2015-05-21 18:28:35 PDT
Created attachment 253570 [details] Patch
Jer Noble
Comment 2 2015-05-21 23:57:43 PDT
Committed r184760: <http://trac.webkit.org/changeset/184760>
Daniel Bates
Comment 3 2015-05-27 14:43:31 PDT
(In reply to comment #2) > Committed r184760: <http://trac.webkit.org/changeset/184760> This broke the internal iOS bots because the file AVPlayerViewController_WebKitOnly.h, included in file Source/WebCore/platform/spi/mac/AVFoundationSPI.h, may not exist.
Daniel Bates
Comment 4 2015-05-27 14:43:49 PDT
As far as I can tell from the looking at the patch we don't seem to make use of
Daniel Bates
Comment 5 2015-05-27 14:44:29 PDT
(In reply to comment #4) > As far as I can tell from the looking at the patch we don't seem to make use > of I meant to write: As far as I can tell from the looking at the patch we don't seem to make use of AVPlayerViewController_WebKitOnly.h. We should remove it.
Daniel Bates
Comment 6 2015-05-27 14:55:30 PDT
(In reply to comment #5) > As far as I can tell from the looking at the patch we don't seem to make use > of AVPlayerViewController_WebKitOnly.h. We should remove it. Filed bug #145414 to remove the inclusion of header AVPlayerViewController_WebKitOnly.h from AVFoundationSPI.h.
Jer Noble
Comment 7 2015-05-27 15:13:05 PDT
rdar://problem/21064692
Radar WebKit Bug Importer
Comment 8 2015-05-27 15:13:42 PDT
<rdar://problem/21130440>
Jer Noble
Comment 9 2015-05-27 15:13:52 PDT
Follow up build-fix landed by Daniel Bates in https://trac.webkit.org/r184924.
Note You need to log in before you can comment on or make changes to this bug.