|Summary:||[GTK] Layout Test http/tests/appcache/different-https-origin-resource-main.html is failing|
|Product:||WebKit||Reporter:||Marcos Chavarría Teijeiro (irc: chavaone) <chavarria1991>|
|Component:||Tools / Tests||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Normal||CC:||berto, bugs-noreply, cgarcia, clopez, commit-queue, danw, gustavo, mcatanzaro, mrobinson, webkit-bug-importer|
|Version:||528+ (Nightly build)|
Description Marcos Chavarría Teijeiro (irc: chavaone) 2015-05-21 03:06:28 PDT
The http/tests/appcache/different-https-origin-resource-main.html layout test is failing on GTK+. It was expected to crash but it is failing after r[r184624-r184632]. The diff is the following: --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/appcache/different-https-origin-resource-main-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/appcache/different-https-origin-resource-main-actual.txt @@ -1,4 +1,4 @@ Test that a resource from a different https origin is not cached. -PASS +ERROR If I try to print the error information I get an empty object.
Comment 1 Carlos Alberto Lopez Perez 2016-02-01 14:39:13 PST
Created attachment 270428 [details] GDB Backtrace for the crash of http/tests/appcache/different-https-origin-resource-main.html on a GTKDebug build of r195954
Comment 2 Carlos Alberto Lopez Perez 2016-02-01 14:42:00 PST
I have observed the following: If the full test suite is run, this tests usually fails. But if this tests is run alone by specifying its name on the command line it crashes. I'm attaching the GDB backtrace for when it crashes.
Comment 3 Carlos Garcia Campos 2016-02-02 08:34:59 PST
Created attachment 270489 [details] Patch There's a use after free when handling tls errors.
Comment 4 Michael Catanzaro 2016-02-02 10:36:28 PST
Comment on attachment 270489 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270489&action=review Thanks Carlos and Carlos. Yet another concrete result to show from our gardening. > Source/WebCore/ChangeLog:3 > + [GTK] Layout Test http/tests/appcache/different-https-origin-resource-main.html is failing Also remove the failure expectation?
Comment 5 Carlos Alberto Lopez Perez 2016-02-02 10:48:25 PST
(In reply to comment #4) > > Also remove the failure expectation? It continues to fail. This patch fixed the crash, but not the test. So I guess that removing the Crash from the expectation and leaving the Failure is the right thing to do.
Comment 6 Carlos Garcia Campos 2016-02-03 02:37:28 PST
Committed r196061: <http://trac.webkit.org/changeset/196061>
Comment 7 Michael Catanzaro 2016-02-03 07:49:13 PST
Reopening because the test is still failing and the expectation is still marked against this bug. Glad we got the crash fixed though.