Bug 145224

Summary: Remove unused MarkedBlock::m_rememberedSet.
Product: WebKit Reporter: Andreas Kling <kling>
Component: JavaScriptCoreAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, kling, mhahnenb
Priority: P2 Keywords: Performance
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mhahnenb: review+

Andreas Kling
Reported 2015-05-20 14:58:12 PDT
The remembered bit is stored in the JSCell, and that's where everyone looks for it. We were keeping an atomic bitmap up-to-date in the MarkedBlock for no reason.
Attachments
Patch (6.16 KB, patch)
2015-05-20 15:05 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Patch (6.76 KB, patch)
2015-05-20 15:13 PDT, Andreas Kling 		mhahnenb: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2015-05-20 15:05:45 PDT
Created attachment 253463 [details] Patch
Andreas Kling
Comment 2 2015-05-20 15:13:06 PDT
Created attachment 253464 [details] Patch
Mark Hahnenberg
Comment 3 2015-05-20 15:20:11 PDT
Comment on attachment 253464 [details] Patch Whoops :-) r=me
Andreas Kling
Comment 4 2015-05-20 15:26:15 PDT
Landed in <https://trac.webkit.org/r184666>
Note You need to log in before you can comment on or make changes to this bug.